Compare at price display

[shopify]

Compare at price display

[NathanPJF]

Update: Other issues with compare at price display:

Compare at price on product page

The logic to display the compare_at_price is problematic. It is only checking the current variant compare_at_price. This means that if the current variant isn't on sale, we never get the necessary markup to handle displaying compare_at_price later.
Line:

slate/src/sections/product.liquid

Line 79 in f4c6f1e

{% if current_variant.compare_at_price_max > current_variant.price %}

The product.liquid page should be using the same logic as the featured_product section and checking the product compare prices. Then JS can handle displaying the compare at price.

Initial compare at price display

The markup for the featured product page is showing product.compare_at_price at the initial render - even when that compare_at_price has nothing to do with the selected variant.

Video: http://take.ms/C8Hnv

In the video, you can see that the variant Baby Blue / 8 / Suede is showing a compare at price initially. Problem: this variant is not on sale. When I switch variants and then switch back, the proper price is shown.

Solution: the initial render should be checking the current_variant inside of the product.compare_at_price check.

Example here

        {% if product.compare_at_price_max > product.price %}
          <span class="visually-hidden">{{ 'products.product.regular_price' | t }}</span>
          <s data-compare-price>
            {% if current_variant.compare_at_price %}{{ current_variant.compare_at_price | money }}{% endif %}
          </s>
        {% endif %}

 

This will have to be considered for both the product template and the featured-product section.

Other issues

product.compare_at_price is undocumented.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.