Giter Site home page Giter Site logo

Comments (4)

dnagoda avatar dnagoda commented on September 6, 2024

@smile-christian Thanks for the report. I've added the issue to our backlog for review.

from ui-extensions.

joshlbaker avatar joshlbaker commented on September 6, 2024

Currently, the native login link is a no-op when clicked from the editor. Is that what we expect when an extension links to login as well? 

Image

Not sure how much control we would have over that.

from ui-extensions.

denislins avatar denislins commented on September 6, 2024

Hey @smile-christian, thank you for reporting this issue.

The checkout preview in the editor works in a very specific way - in general, this means it's a bit limited, and that many extensions can't work as they would on a real checkout. For Link specifically, we're working now on preventing it from working on the editor, or at least limiting how it can be used - we haven't decided what's best yet.

In any case, my recommendation is to use the editor flag to create a bespoke editor experience for extensions. In your case, maybe skipping the login when in the editor and using a fake customer to render your extension could work well, for example - although it's hard to tell without knowing more about your use case.

I'll keep this issue open until we roll out the changes to Link, and I'll update this ticket when we do.

from ui-extensions.

denislins avatar denislins commented on September 6, 2024

Hi @smile-christian, we've recently rolled out a change to how external links work on the editor - when clicked, they will now prompt a confirmation pop up, which when confirmed by the user will open the link on a new tab.

Thank you again for reporting the issue!

from ui-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.