Giter Site home page Giter Site logo

bricks color theme about vscode-shopify-ruby HOT 6 CLOSED

shopify avatar shopify commented on September 26, 2024
bricks color theme

from vscode-shopify-ruby.

Comments (6)

vinistock avatar vinistock commented on September 26, 2024

Hello! What do you mean with "bricks my color theme"?

The Ruby LSP provides semantic highlighting information, which might change how the theme highlights your code - especially if it does not take semantic information into account.

from vscode-shopify-ruby.

h0jeZvgoxFepBQ2C avatar h0jeZvgoxFepBQ2C commented on September 26, 2024

it should look like this (Ruby LSP disabled):
Bildschirmfoto 2023-11-23 um 15 56 36

But with Ruby LSP enabled it looks like this (all colors are broken somehow):
Bildschirmfoto 2023-11-23 um 15 55 45

Is it possible to stop somehow the color changes?

from vscode-shopify-ruby.

vinistock avatar vinistock commented on September 26, 2024

You can configure the Ruby LSP and turn off semantic highlighting if you wish.

The reason the colours all seem the same is likely because the theme is not using the semantic information to highlight the code.

For example, method declarations and invocations use the method.declaration and method semantic tokens, respectively. If the theme doesn't differentiate based on semantic token modifiers, then it's likely assigning the same colour to both token types.

All that is to say, if the theme started handling the Ruby LSP's semantic information, it would likely look significantly better.

from vscode-shopify-ruby.

h0jeZvgoxFepBQ2C avatar h0jeZvgoxFepBQ2C commented on September 26, 2024

Yeah i tried and even disabled all features, but it still overwrites (also after window reloading) my theme?

from vscode-shopify-ruby.

h0jeZvgoxFepBQ2C avatar h0jeZvgoxFepBQ2C commented on September 26, 2024

Bildschirmfoto 2023-11-23 um 16 12 19

from vscode-shopify-ruby.

vinistock avatar vinistock commented on September 26, 2024

Do you have any other Ruby related extensions installed? It might be the grammar file bundled in Ruby LSP, but that's the same grammar file that was previously bundled in Rebornix Ruby.

from vscode-shopify-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.