Comments (5)
Hi @svlauer,
thank you for your contribution.
In general I would agree to document the new component_filter_panel_items
because it is very unlikely to change compared to specific filters. However there may be cases where the developer want's to have a new filter before or after another filter. Maybe we could document the component_filter_panel_items
as the primary solution and then add another sentence like "If you need your filter next to a specific filter, you can also use the filter's individual blocks e.g. component_filter_panel_item_shipping_free
{code_exmample}".
For the version: I think you could prepare an info box in your pull request which stays open until it is clear in which version the block will be released. Approximately this could be v6.4.8.0
:
{% hint style="info" %}
The block `component_filter_panel_items` is available from Shopware Version 6.4.8.0
{% endhint %}
from docs.
This sounds sensible. Given the (suboptimal) hardcoding of the order of the filters provided by core, it is good to have the additional hint, as you suggest.
Thank you for the tip with the info box! I plan to roll a pull request soonish.
from docs.
Quick question (not sure if this is the best place to ask - feel free to tell me to go somewhere else):
Is there a way for me to "build" the documentation locally, to test my changes before doing a pull request? I can of course test the basic markdown easily, but what about {% code %}
or {% hint %}
directives? (I am not familiar with gitbook, and looking at their website is not terribly helpful ...)
from docs.
Hi @svlauer. Thank you a lot for the pull request! As of now, unfortunately, we're unaware of a proper way to preview the changes. I propose that we will review the published article, once the PR has been merged and, if necessary, make some quick fixes.
from docs.
Thanks for the explanation! Ok ... the template tags are simple enough, so probably everything is going to be fine. But it felt wrong to do a PR without proper testing ... (and I thought I must have missed something).
from docs.
Related Issues (20)
- CSRF was removed in 6.5 but still in docs. HOT 2
- Inherit iconSets HOT 4
- Was plugin description removed from composer.json? HOT 4
- Entity Extensions: add association between existing entities HOT 1
- Add to EntityExtension page: HOT 6
- Run lychee to find dead links HOT 5
- Guide "Add custom flow Action" not working for Shopware 6.5.0.0+ HOT 3
- Documentation for adding a custom Storefront controller (the service definition) seems worng HOT 2
- seo route option - mentioned and used in core but what does it actually do? still used? HOT 3
- some documentation pages seem to still mention old annotations like @LoginRequired (not in migration conext) HOT 6
- documentation sometimes uses attributes, sometimes annotations - should probably only use attributes now HOT 3
- twig custom function documentation - naming convention HOT 5
- Test
- Where can one finde JS-plugins from plugins installed via composer? HOT 2
- Documentation lists "shopSecret" in Confirmation request which is probably not the case HOT 2
- Add Data to Storefront Page - Tutorial Issue HOT 3
- Add Admin Search variables in "Set up Elasticsearch"-article HOT 1
- Just the file extension in config/packages HOT 4
- Flow-Builder Action is not documented correctly HOT 4
- Non-existent class referenced for Unit testing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docs.