Comments (2)
@paviad In my opinion the desired behaviour with parseImgDimensions
set to false
shouldn't result in the following html:
<p>![my image](./pic/pic1_50.png =100pxx20px)</p>
<p>![my image2][1]</p>
<p>[1]: ./pic/pic1_50.png =100pxx20px</p>
It should rather just omit the dimensions and fill in the html with proper values while leaving the dimension attributes, like the following:
<p><img src="./pic/pic1_50.png" alt="my image" /></p>
<p><img src="./pic/pic1_50.png" alt="my image2" /></p>
Because the important point to note here is that if we're setting parseImgDimensions
to false
that means we want the image to be displayed in its original dimensions regarding of the dimensions provided in the markdown syntax.
Note, we still want the image to be displayed but, not with the dimension attributes.
And the fix you've provided here #985 (which is highly appreciated) does not let the image render rather it just puts the markdown syntax in its place which is not the desired behaviour of a markdown to html converter.
I hope you'll look into it and you'll try to come up with a different approach.
from showdown.
It is definitely a viable alternative to my design - I can make it so.
from showdown.
Related Issues (20)
- markdown from openAi streamed data gives weird results
- Showdown escaping HTML Chars but not constantly HOT 1
- Incorrect Regex in "Add default classes for each HTML element" Wiki Page
- superscript and subscript not working HOT 1
- Data Science ANnd Machine Learning
- Error in parsing hashtag at start of line
- Issues installing this package with React version >= 17 HOT 1
- URL not converting properly
- Links without protocol are threated as links, but behave as path
- Strikethroughs won't render. HOT 2
- showdownJS Domain expired HOT 1
- NPM installation browser support HOT 2
- [Suggestion] Markdown to array of objects
- Potential Security Issue
- Vulnerability Reporting
- Request for Security Contact HOT 1
- ghCodeBlocks set to false but keeps rendering <code> and <pre> tags
- Tables dont work in normal llm formats
- Yaml-like Metadata parser does not handle colons in entries; returns undefined HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from showdown.