Comments (8)
I don't really want to reinvent the wheel here. IMHO we should reuse the side
by side diff logic from Gerrit, but of course that's currently impossible
because Gerrit uses GWT, and does various other things wrong. So, first let's
fix Gerrit.
Original comment by [email protected]
on 11 Nov 2012 at 11:19
from gitiles.
Gerrit is looking at moving to Codemirror for side-by-side diffs. We should do
that too: not too much fancy JS, hopefully largely pasting it in, I haven't
looked. Even if not, we should be able to reuse more code because it's just the
server-side stuff (serving diff info), no more GWT.
Original comment by [email protected]
on 19 Jun 2013 at 12:26
from gitiles.
For reference, I requested this via email as something that I think is
important for parity between ViewVC and gitiles if Chromium is moving from the
former to the latter.
Original comment by [email protected]
on 5 May 2014 at 4:26
from gitiles.
Can/should it be optional? I personally prefer the single format.
Original comment by [email protected]
on 6 May 2014 at 10:58
from gitiles.
Original comment by [email protected]
on 26 Aug 2014 at 12:06
from gitiles.
Any update on the prospects for this?
Original comment by [email protected]
on 26 Aug 2014 at 12:08
from gitiles.
Issue chromium:384604 has been merged into this issue.
Original comment by [email protected]
on 26 Aug 2014 at 12:16
from gitiles.
Nope. :(
IIRC we tried using CodeMirror3 and it was too slow/awkward to use for Chromium
project. So a new side by side view needs to be built from scratch in Gitiles,
but that work hasn't been estimated or scheduled.
Original comment by [email protected]
on 26 Aug 2014 at 12:21
from gitiles.
Related Issues (20)
- Documentation (even cursory/automatic) of the REST api would be awesome HOT 4
- format=TEXT for +diff handler HOT 9
- Log view is slow HOT 7
- File view is slow (slower than same file's blame view) HOT 6
- add golang meta import tag HOT 1
- Feature request: make json format of revisions range log in googlesource also return changed files HOT 1
- Feature request: show all refs from which a commit is reachable on /+/<hash> pages
- log graph view
- pretty=fuller view broken in some places HOT 1
- Render markdown (README.md) HOT 4
- [blame] links should show blame for parent of the commit.
- Add option for embedded (iframe) Gitiles views. HOT 1
- File diff link in fuller log view incorrect HOT 2
- Can't ctrl-f search for line numbers in file view
- follow file history across renames/etc...
- [deleted issue]
- [deleted issue]
- [deleted issue]
- copy of source code snippet drops blank lines
- Markdown multilevel lists aren't recognized correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitiles.