Image Issue

[m1-key]

Image Issue

[m1-key]

@shivbhosale Thanks a lot. This Jupyviewer is really awesome component.

[shvbsle]

1. Can you provide an example of how you are trying to upload an image?
2. I'm using a third-party markdown-parser; react-markdown https://github.com/rexxars/react-markdown
   It currently doesnt support super-script or sub-script

[m1-key]

1. Can you provide an example of how you are trying to upload an image?
2. I'm using a third-party markdown-parser; react-markdown https://github.com/rexxars/react-markdown
   It currently doesnt support super-script or sub-script

@shivbhosale ![alt text](https://github.com/m1-key/Thug-Life/blob/master/mask.png "Logo Title Text 1")
I used this , but only no image is displayed. If I tried uploading the image locally same happened. I used <img src = "Location_Of_Image" alt = "Alternate text " >. But in each case I failed to upload the image.

[m1-key]

@shivbhosale reply ?

[shvbsle]

@m1-key Apologies for late response!
I understand your confusion but the URL that you provided doesn't actually point to an image!
It points to a webpage.

Notice the difference:
wrong url
https://github.com/m1-key/Thug-Life/blob/master/mask.png

right url
https://raw.githubusercontent.com/m1-key/Thug-Life/master/mask.png

Wrong way

![alt text](https://github.com/m1-key/Thug-Life/blob/master/mask.png "Logo Title Text 1")

Right way

![alt text](https://raw.githubusercontent.com/m1-key/Thug-Life/master/mask.png "Logo Title Text 1")

I am able to render the image with the following code:

<JupViewer
          title="Jupyter as a Blog!"
          subtitle="I've always wanted to publish my jupyter notebooks as blogs. Finally I can."
          coverImg="https://raw.githubusercontent.com/m1-key/Thug-Life/master/mask.png"
          // file={ipynb}
          file="https://raw.githubusercontent.com/jakevdp/PythonDataScienceHandbook/master/notebooks/00.00-Preface.ipynb"
          // file="https://raw.githubusercontent.com/fastai/course-v3/master/nbs/dl1/00_notebook_tutorial.ipynb"
        />

Edit 1: In general, if you are sourcing any file from github, take care of the URLs. github hosts the actual raw data on domain:
https://raw.githubusercontent.com and not https://github.com

[m1-key]

@shivbhosale I met with an issue while passing dynamic ipynbs . i.e when user click on button A it loads notebook A, when user click on button B it loads notebook B. But I am unable to do so.
Here is the screeshot of the code :

Here is the output :

[shvbsle]

@m1-key Hi Mithilesh. I'm sorry but, I'm seeing this just now. I dont get notified of a comment made on an issue that is already closed! Please consider opening a fresh issue else I wont be notified right away.

Currently the component does not support component-refresh on prop update. Let me try to add this feature over the weekend!

Edit:
https://join.slack.com/t/reactjupytern-0nc7370/shared_invite/zt-gacg79oi-NYk9coLNBUXiqtQ80ohMKg

Join this slack channel in case you need to reach out