Violation of Sidekiq Best Practices

[pboling]

Violation of Sidekiq Best Practices

[markets]

Hello @pboling 👋🏼

Ok yes, you're right! I think we should probably update those docs to clarify what it means in the Sidekiq-Cron context, but using the "official" Sidekiq terminology. Here we have a more detailed description about how this gem works under the hood: https://github.com/sidekiq-cron/sidekiq-cron?tab=readme-ov-file#under-the-hood. But in summary, in that paragraph it means "process".

[markets]

No prob @pboling! I'm also maintaining a lot of open source projects and I know that feeling 😅

I'll try to take a look asap. I now think that's an important detail to document well and probably some quick replace "worker" => "process" (in the README file) will make the job.

Thanks for pointing out this documentation issue! And of course, if you find the time and the motivation, I'd really happy to review and merge a PR in this direction.

PS I'll keep the issue open until this is fixed

[markets]

@pboling Pushed this clarification here: abdb335. Please, feel free to send any feedback or improvement.

[pboling]

@markets I'd love to! Will try to get to it by the weekend.

[markets]

@pboling Would you mind to send a PR addressing those documentation fixes?

[markets]

Hello @pboling,

Did you had the chance to prepare a PR to enhance these docs? Would love to have this clarification in place for future readers.

[pboling]

Sorry, no. Everything I am working on is critical at the moment and I'm over subscribed.