Comments (4)
I've seen very little demand for this type of functionality so I don't plan on implementing this myself. If Redis is down, we have no access to reliable storage. Sidekiq cannot depend on log output or the filesystem for a reliable storage between reboots. If you want to provide additional safety with your own patches, I think that's great. If you want to submit a PR with changes which make your patches more maintainable, I'd welcome them.
from sidekiq.
Hi Mike,
Thanks for your prompt response. We understand your concerns, and we appreciate your suggestion to provide additional safety with our own patches.
To address the potential loss of jobs during unexpected process exits, our proposal is inspired by the sidekiq_retries_exhausted
hook. We don't intend for Sidekiq to rely on log output, the filesystem, or any specific storage mechanism. Instead, we envision allowing the application using Sidekiq to decide how to proceed with the unpushed jobs.
We're considering two potential methods like for example:
-
reliable_push_limit_reached
:
This hook would be triggered when a limit is reached, enabling users to take specific actions for individual jobs.reliable_push_limit_reached do |job| # Custom actions for handling the job end
-
reliable_push_jobs_on_exit
:
This hook would be invoked when jobs are in danger of being lost due to process exits, providing an opportunity for users to implement recovery strategies.reliable_push_jobs_on_exit do |jobs| # Custom actions for handling the list of jobs end
About contributing to a Sidekiq Pro feature, what's the best way to go about it? If you have some guidance, that would be great.
Thanks again,
from sidekiq.
I'm not interested in further refinement of this feature. I don't believe your suggestions would add any more real world reliability. It requires the user to provide the code, would be hard to integration test and infrequently executed.
Look into reconciliation instead: https://www.mikeperham.com/2014/05/27/the-reconciliation-step/
from sidekiq.
Alright,
We are not entirely sure how distinct this would be from 'sidekiq_exhausted_retries' on the server side, as both aim to provide an alternative when Sidekiq can't do anything else with the jobs and to help with the 'reconciliation'.
In any case, thanks once more. We'll figure out how to handle it on our end.
from sidekiq.
Related Issues (20)
- Sidekiq Pro CVE Patch HOT 1
- Regarding CVE-2022-23837 study notes HOT 1
- Why is Sidekiq ignoring the url option within a Redis sentinel configuration? HOT 4
- Pending batches expiring in 5 months, not 30 days HOT 6
- Feature request: add flag to opt in/out of Process.warmup HOT 7
- `Object#respond_to_missing?` redefined with too few arguments HOT 2
- Sidekiq Web: Unhandled can't convert String into an exact number (TypeError) HOT 15
- Errors after configuring pro web ui with redis pool HOT 5
- [Feature Proposal] Compressing scheduled jobs to save memory HOT 5
- Difference between capsule and concurrency=1 HOT 3
- Suggestion: Raise error when calling `batch.jobs` more than once when defining the batch? HOT 2
- Capsules don't observe the `-q` parameter of their process HOT 2
- Update Sidekiq API with capsule data HOT 1
- set(unique_for: ...) not working with ActiveJob HOT 3
- Batches wrapping unique_for jobs completing before jobs have run HOT 5
- "Error fetching job" after upgrade to Sidekiq 7 HOT 8
- Worker not running in schedule.rb HOT 7
- Sidekiq::Limiter.unlimited does not comply with signature of other limiters
- Jobs Stuck in Enqueue state (Enqueued Actionmailer) HOT 20
- Current attributes lost after inline execution HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sidekiq.