Add a flag to ignore some results

[DawidOskwarek]

Add a flag to ignore some results

[sidvishnoi]

Not as of now, but it's something I want to support. Both ignoring errors/warnings and ability to not test specific link/patterns. Will need some time and energy for that. PRs welcome.

BTW, you can ignore the result by using the node library (instead of CLI).

(This project is unmaintained as of now)

[sidvishnoi]

Keeping it open for future.

[DawidOskwarek]

@sidvishnoi

I was playing around with the tool and found few issues which make it not reliable. Not sure if this tool will be supported in the future but I'm just leaving the two main issues here if anyone wants to ever look into it.

1. Sometimes the tool doesn't scan the website at all, it will run the command and return nothing. The scan did not occur and there is no error code. Basically it returns as success without a scan. It will usually happen twice for every 10 tries/scans for me
2. When you set concurrency option to 1 then it will not scan all the pages on the website, but if you set it to 2 or higher then it will scan everything

Great tool overall, I think it would be useful for a lot of people but at the moment I believe it needs few fixes. Thanks for your help

[DawidOskwarek]

Thanks for the response, do you have an example of how link can be ignored using the node library? Thanks again!

[sidvishnoi]

From the README, something like following:

const { checkLinks } = require("href-checker");

for await (const result of checkLinks(url, options)) {
	console.log(result.type);
	// -> "samePage", "sameSite", "offSite"

	console.log(result.input);
	// -> {
	//     "link": string,           // URL of page being visited.
	//     "count": number,          // Number of occurences of URL.
	// }

	console.log(result.output);
	// -> {
	//     "pageExists": boolean,   // Page resolved with HTTP 20* code.
	//     "status": number,        // HTTP status code.
	//     "fragExists": boolean,   // Element corresponding to fragment exists.
	//     "error": Error,          // Error, if any.
	// }

        if (!result.output.pageExists) {
                if (result.output.link === SOME_LINK) {
                        // do nothing
                } else {
                        // log warning/error
                }
        }
}

You can also check how the CLI does it: https://github.com/sidvishnoi/href-checker/blob/main/cli.ts

[DawidOskwarek]

Thank you, will play around with it

[sidvishnoi]

1. Sometimes the tool doesn't scan the website at all, it will run the command and return nothing. The scan did not occur and there is no error code. Basically it returns as success without a scan. It will usually happen twice for every 10 tries/scans for me

Can you share the URL? Or does it happen with almost every URL?

Can you file separate issues for above? Thanks!