Giter Site home page Giter Site logo

Comments (3)

adityasaky avatar adityasaky commented on August 17, 2024

cc @marcelamelara @TomHennen @pxp928 @joshuagl @mikhailswift

from protobuf-specs.

kommendorkapten avatar kommendorkapten commented on August 17, 2024

Is the idea to just have a single dependency to depend on for being able to unmarshal a work with a bundle?

I might be wrong here, haven't thought this through in detail, but a client would still need to perform two JSON unmarshal passes.

The DSSE envelope captuers the payload as a byte stream, which means that we can't rely on a single run of protojson unmarshal, as the final struct will contain a byte array, that has to be JSON parsed again to get the in-toto statement.

from protobuf-specs.

woodruffw avatar woodruffw commented on August 17, 2024

Is the idea to just have a single dependency to depend on for being able to unmarshal a work with a bundle?

That, plus flattening the subdependencies here: if a dependant includes both sigstore-protobuf-specs and in-toto-attestation in Python, then they'll end up with two different Protobuf runtimes (betterproto and protobuf, respectively). This arguably isn't a big deal at all but it set off my "ick" alarm 🙂

I might be wrong here, haven't thought this through in detail, but a client would still need to perform two JSON unmarshal passes.

Correct -- I believe the main value here is not in having the two unmarshal as part of the same "pass," but just in having the data models collected together.

from protobuf-specs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.