Resolve function is necessary when a built-in scalar can be undefined

[Emilios1995]

Resolve function is necessary when a built-in scalar can be undefined

[sikanhe]

GraphQL does not understand undefined. You want resolve: ({minPrice}) => minPrice ?? null

I get that its a little inconvenient though. I actually suggest you changing the type definition of SearchCriteria to use number | null

[sikanhe]

@Emilios1995 the version [email protected] contains this change is on npm, let me know if you can try it out

[Emilios1995]

GraphQL does not understand undefined. You want resolve: ({minPrice}) => minPrice ?? null

I get that its a little inconvenient though. I actually suggest you changing the type definition of SearchCriteria to use number | null

Thanks for answering. I understand that absent fields have to be represented as null rather than undefined because otherwise they would be missing from the serialized JSON, but I was under the impression that graphql-js will just convert undefined values to null—isn't that the case?

[n1ru4l]

@Emilios1995 Actually you are right: https://stackblitz.com/edit/graphql-pkmsvz?file=index.js

[sikanhe]

Mhmm good catch - maybe we should do this

[sikanhe]

PR to fix this in #65

[sikanhe]

In master

[Emilios1995]

Thanks a lot!