Comments (3)
I've generally wanted to avoid adding new dependencies to the project and prefer to just let users configure what they need.
Is there any reason that just adding agentkeepalive
to your project and passing it in via the agent
option doesn't work?
from node-consul.
Is there any reason that just adding
agentkeepalive
to your project and passing it in via theagent
option doesn't work?
I can do that and planned to. I'm already overriding the agent and was in the process of adding agentkeepalive
. I'm also leaving a note here in case others run into similar slow leaks of inactive sockets, though I still haven't confirmed it's the case.
Separately from that, even without adding agentkeepalive
, I'd still recommend setting the timeout
to something larger than expected papi timeout - it defaults to infinite. in https://nodejs.org/api/http.html#new-agentoptions
timeout number Socket timeout in milliseconds. This will set the timeout when the socket is created.
from node-consul.
It looks like issues I'm seeing are possibly unrelated to idle connections, the consul agent was running locally on the affected applications, so it's probably not networking, but remotely possible to be timeouts. At the time, nobody ran ss --tcp --numeric
to see how many consul connections or other connections there were to localhost:8500.
Unrelated: The consul agent deliberately disables http keep-alive by design for all outgoing requests, so the golang agent isn't affected by idle timeouts, either.
from node-consul.
Related Issues (20)
- access to keys response HOT 3
- TypeError: consul_1.default is not a constructor HOT 1
- TypeScript Support for consul.query HOT 1
- There is no accessible history.md or changelog.md file HOT 1
- Consul queries providing `tag` are deprecated HOT 2
- Long Polling index should be verified > 0 after initial response
- Reset index of watch job if index ever decreases HOT 1
- Can't invoke "new Consul()" HOT 1
- Can't invoke "new Consul()" constructor in typescript app HOT 1
- Release docs? HOT 4
- Typescript support for client.watch HOT 1
- Typescript suppor for grpc healthcheck's HOT 1
- Add Typescript support HOT 2
- Grype scanner found all this vulnerabilities in the library CVE-2018-25046, CVE-2020-13250, CVE-2021-38698, CVE-2022-40716, CVE-2020-7219, CVE-2020-28053, CVE-2021-3121, CVE-2021-37219 HOT 1
- support for kv.List HOT 2
- extend host:port to support multiple agents HOT 4
- Don't set x-consul-token if it's undefined
- how to watch service?
- Grpc Check register request ignores `tls_skip_verify` HOT 4
- Question about the usage of "end" function in watch.js HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-consul.