\unicharchart is broken in SILE 0.10.0

[sile-typesetter]

\unicharchart is broken in SILE 0.10.0

[alerque]

First, it's SILE with an e (not SIL, a typo also found in the latest release notes on this project).

“A-n-n looks absolutely dreadful; but Anne-with-an-e is quite distinguished.” — Anne Shirley

Second, I'd be happy to help fix whatever broke for you guys, but I don't see exactly where this is happening. I'm guessing you are doing some sort of type casting between node types, which probably means you aren't using the new Penlight based class instantiators properly.

[alerque]

I found your problem, I'll send a fix in a minute.

[jvgaultney]

Thanks! Simon wrote that command, so I would have little ability to troubleshoot it myself. BTW - thanks for catching the typos. I think I've fixed them.

[alerque]

The things I just fixed fall into 4 categories:

• Style cleanup, irrelevant to the problem but fixed it while I was mucking about.
• Stuff that was bound to break because it was not using the correct calls to SILE in the first place. There were a couple of bits that were actually leveraging bugs in SILE's implementation, and fixing those loopholes was bound to make those a problem.
• Stuff that broke because the deprecations in v0.10.0 did not go as planned: a mixup on my part on some nodefactory items being functions and others being objects meant that the compatibility layer did not throw the correct warning. I may try to fix this is a point release of SILE, but either way this should work for current and future versions.
• Stuff that wasn't broken yet, but is going to be deprecated.

Sadly there is yet a fifth kind of thing I noticed we're going to break on you in a future release. We'll document the change when it comes out, but the document class system here is going to need to be replaced for some future version of SILE. Feel fee to come find me and I'll help port this when the time comes.

[alerque]

As if that wasn't enough different kinds of fixes, I just fixed some of the type checking upstream so this won't be a problem for anybody else before warning messages explaining what is happening get enabled. Expect v0.10.1 of SILE shortly, and it your code should work as is on that version. That being said all the things I contributed in the PR are still valid fixes and will need to be done sooner or later anyway.

[jvgaultney]

So you're saying I need to wait until 0.10.1 for your changes to work?

[jvgaultney]

I won't accept pull requests that depend on an unreleased version of SILE

[alerque]

@jvgaultney No that's not what I'm saying. Sorry my explanation is a bit fuzzy, I'm just recovering from a long bought of fever and I'm still a bit fuzzy!

The proposed changes in #7 will fix the problem here now for the currently released SILE v0.10.0.

At the same time this should not have been a problem in SILE in the first place, and v0.10.1 will include an upstream fix that would have the effect of making this projects code work again as it is now with no changes — at least temporarily. The interfaces it uses will eventually be deprecated so you should go ahead and merge #7 anyway as it makes use of the proper v0.10.0 interfaces and stops using the V0.9.x ones that will be dropped eventually.

[jvgaultney]

Great - thanks for the explanation. I'll test your PR tomorrow. Thanks for your help!

[alerque]

SILE v0.10.1 has been released and addresses the regression that caused the failure here. That being said everything in #7 should still be applied as it deals with the deprecation warnings that will be raised (and I slipped in a small fix for one deprecated call I missed, the warnings in v0.10.1 make it a lot easier to actually spot them all!).

[jvgaultney]

I have merged the pull request, and now \unicharchart works again, however I'm getting warnings I did not receive before:

sile fpUnichar.sil
This is SILE v0.10.1
<fpUnichar.sil>

! Underfull frame: 155.37813936pt stretchiness required to fill but only 101pt available at fpUnichar.sil: in \bigskip near 4:1: in \unicharcharttable: 0x7fae11cf1970
[1] 
! Underfull frame: 170.6584127975pt stretchiness required to fill but only 100pt available at fpUnichar.sil: in \bigskip near 5:1: in \unicharcharttable: 0x7fae11cf1cb0
[2] 
! Underfull frame: 230.7244284225pt stretchiness required to fill but only 106pt available at in "␤␤"
[3] [4] 

Is there a way to reduce the likelihood of these warnings? The PDF is fine, but the warnings are annoying.

[alerque]

This is exactly the same issue as #9, lets close this and track it there instead as \unicharchart is fixed.

[jvgaultney]

Closing - see #9