Inject Application into before/after filters, controllers.

[silexphp]

Inject Application into before/after filters, controllers.

[awildeep]

I think this could be a good recipe. Doing this by default I think is slightly confusing to someone who is used to closures in PHP right now. If we default this behavior, then we have BC issues.

It is too bad we can't define the variable on creation of the closure.

[igorw]

What kind of BC issues? Closure use-statements will still work.

[stof]

@awildeep the point is that this requires changes in the core so it cannot be done as a recipe.

[stof]

@igorw the issue would be for routes. If the app is passed as first argument by the Application and you don't update your code, you have an issue because you expect to get the first routing placeholder as first argument.

[awildeep]

@stof; Yea I see your point. I didn't catch it before in a quick glance.

@igorw; stof explained my BC issue. For some clarity if I have existing code like:

$app->get('/test/{variable}', function ($variable) use ($app) { ....});

It would change to this:

$app->get('/test/{variable}', function ($app, $variable) { ....});

This effectively forces any existing code to need to be reworked, thus breaking BC. Not a big deal to me right now as this is a fairly simple change, but existing developers may not know how to handle the change and cause a lot of issue tickets after they upgrade.

Just as a side note: I like this change and I am for it, if I gave you a negative impression my bad. I am just concerned about existing applications.

[igorw]

No, my suggestion is to use a param converter, and check if there is a $app argument. So it will be injected based on the name (or the type, through type hinting).

[awildeep]

Edited; I removed my question, no need to ask it.

Also; this is much better than I thought it was. I guess this will encourage developers to always name their application object $app more as well for consistency.

Hello there, this is already possible thanks to @fabpot.

See: 934bf3e

[igorw]

Yep, it works through type hinting, which I suggested as an alternative. Closing this, thanks!