Giter Site home page Giter Site logo

Comments (6)

zsluedem avatar zsluedem commented on July 28, 2024

Currently, each test would start a geth node by itself. Do you mean start only one and put it in the backgroud?

from silius.

Vid201 avatar Vid201 commented on July 28, 2024

Yes, that's the idea. A lot of unit tests also need a geth client since several checks depend on that (e.g., https://github.com/Vid201/aa-bundler/blob/main/src/uopool/services/sanity_check.rs#L356).

We could run geth in the background, deploy all necessary contracts (and possibly do other things) before running tests.

from silius.

zsluedem avatar zsluedem commented on July 28, 2024

I used to have problems with one big Geth dev mode because the rust tests are running in parallel. Then nonce is a little bit tricky.

from silius.

Vid201 avatar Vid201 commented on July 28, 2024

Hmm, you're right. Ok, then let's leave this for now.

from silius.

zsluedem avatar zsluedem commented on July 28, 2024

Hm.. Maybe the problem is that I kept using the same wallet to do the test. Instead, we could have a new wallet for each test. In that case , nonce is not the problem.

from silius.

Vid201 avatar Vid201 commented on July 28, 2024

Just adding here: update canonical sanity check test to use local geth (relying on some RPC provider is not the best option). We can also enable simulateValidation tests on entrypoint then.

from silius.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.