silnrsi/anvil

Simple script to help run dockerized smith

anvil's Issues

backup-wsl-repositories.bat suggestions

Personally I think the script is too noisy.

Examples:

• With just 9 font repos it produces over 1000 lines of output to the terminal whether or not it actually has to back up any files. And the lines it outputs are just the names of directories, so we can't actually see what files were backed up.
• If I remove a repo from repos/wstechfonts, then on the next backup every file in the previously backed up copy of that repo generates an *EXTRA File ... line to the screen as it is being deleted, and apparently there is no switch to turn this off.

My proposal would be to first remove the /NFL option (so we can see what files were actually backed up if we need to) and then write everything to a log file that gets overwritten on each use. e.g.:

set LOG="%USERPROFILE%\WSL-repositories-backup.log"
...
robocopy W:\home\%WSL-UBUNTU-USER%\repos\wstechfonts  %BACKUPDIR%  /MIR /FFT /Z /ETA /NP /LOG:%LOG%

NB: The /NP option quiets an extra line for every file saying the percentage of the file copied, which seems to always be 100%.

And, again this is my personal taste, I think there is no reason for the PAUSE statement at the end. If someone wants to run this by double-clicking something (rather than from an existing cmd prompt) they can set up a shortcut to cmd /K path\backup-wsl-repositories.bat in order to be able to read the output.

backup-wsl-repositories.bat + editable fonttools

I followed WF105 instructions Installing a python library in editable mode in order to test fixes that had been pushed to github.com/fonttools/fonttools. All seem to work fine, and my tests were successful.

Unfortunately, however, it seems now that backup-wsl-repositories.bat no longer completes.

It turns out that the fonttools repo contains a symlink:

❯ ls -l fonttools/Snippets/fontTools
lrwxrwxrwx 1 builder builder 16 Aug 23 20:02 fonttools/Snippets/fontTools -> ../Lib/fontTools

and ROBOCOPY burps when it hits that file. The tail of the logfile has multiple copies of:

ERROR 1921 (0x00000781) Copying File W:\home\bobh\repos\wstechfonts\fonttools\Snippets\fontTools
The name of the file cannot be resolved by the system.
Waiting 30 seconds... Retrying...```

I don't know if ROBOCOPY will eventually get tired of trying and go on -- I didn't have the patience to wait. Nor do I know if ROBOCOPY has ways to work around this problem. If not, maybe we just put a note in WF105 that if Windows users are cloning fonttools into the container then they must remove that symlink so that backup-wsl-repositories.bat will still work.

comments ≠ code ?

In .wslconfig:

# Limits VM memory to use no more than 4 GB, this can be set as whole numbers using GB or MB
memory=16GB 

# Sets the VM to use two virtual processors
processors=8

the comments don't appear to match the code -- unless I'm not understanding something.

Unknown key in .wslconfig

In .wslconfig the following:

anvil/.wslconfig

Lines 19 to 20 in e9e86f0

	# Disable page reporting so WSL retains all allocated memory claimed from Windows
	pageReporting=true

generates a Warning during WSL startup:

Unknown key 'wsl2.pageReporting' in C:\Users\bobh\.wslconfig:20

On my machine this warning is visible using Event Viewer