Giter Site home page Giter Site logo

Comments (17)

UndefinedOffset avatar UndefinedOffset commented on July 16, 2024

I wonder if its the case that language files in themes are not read, try moving it to mysite/lang/en.yml see if that works. Likely the manifest does not look in themes for language files.

from silverstripe-framework.

g4b0 avatar g4b0 commented on July 16, 2024

You're right! I moved YAML content into mysite YAML files and everything is ok, now. So it's a bug!

sake /dev/tasks/i18nTextCollectorTask 

generates the english YAML file into themes/mySimple, but SS will never read it and it's translated counterpart.

from silverstripe-framework.

UndefinedOffset avatar UndefinedOffset commented on July 16, 2024

Ya i18nTextCollectorTask should be putting it into your site project for themes and not in the theme

from silverstripe-framework.

g4b0 avatar g4b0 commented on July 16, 2024

Maybe is better that theme folder is readed during translation, so it will be possible to translate templates.

from silverstripe-framework.

UndefinedOffset avatar UndefinedOffset commented on July 16, 2024

Main problem with that is that themes aren't interpreted like modules, which is what i18n uses to look up the available translations. If I'm correct i18n uses getModules() from the manifest see https://github.com/silverstripe/sapphire/blob/3.0/i18n/i18n.php#L1695 for example.

from silverstripe-framework.

g4b0 avatar g4b0 commented on July 16, 2024

You're right, but themes have to be translated in some way, so I think that's a quite big SS issue.
If you release a theme you can't publish it translate into 2 or more languages, and everyone installing it have to translate it manually.

from silverstripe-framework.

wernerkrauss avatar wernerkrauss commented on July 16, 2024

bump. any progress on this issue?

from silverstripe-framework.

wernerkrauss avatar wernerkrauss commented on July 16, 2024

Seems like this issue is solved in at least 3.1.6.

/dev/tasks/i18nTextCollectorTask?module=themes/mytheme collects stuff
/themes/mytheme/lang is noticed and translation files are added / used

from silverstripe-framework.

sminnee avatar sminnee commented on July 16, 2024

@wernerkrauss are you happy for us to close the issue, then?

from silverstripe-framework.

g4b0 avatar g4b0 commented on July 16, 2024

As @wernerkrauss stated this issue seems solved in 3.1.6

from silverstripe-framework.

g4b0 avatar g4b0 commented on July 16, 2024

It seems that the problem is still around in 3.1.8

from silverstripe-framework.

daddymana avatar daddymana commented on July 16, 2024

I confirm that this error persists on 3.1.8 version

from silverstripe-framework.

chillu avatar chillu commented on July 16, 2024

I've just tried this out in the 3.1 branch, works for me. Check i18n::include_by_locale(), it does a scandir($themesBase) - which has been there for a while (2011). One bug which might be related: i18n::get_existing_translations() doesn't run the same checks on /themes, so in cases where the locale ONLY exists in /themes this might be an issue. Since your example uses it, that's not applicable here though.

from silverstripe-framework.

krv avatar krv commented on July 16, 2024

I can confirm this bug. My /themes/mytheme/lang/nl.yml file was not recognized. When I added the same content to my mysite/lang/nl.yml file everything worked fine.

I created the translation in a template file (Includes/Navigation.ss)

<li><%t Navigation.BELGIUM "Belgium" %></li>

My nl.yml file looks as follows

nl: Navigation: BELGIUM: België

I am running the latest silverstripe version.

from silverstripe-framework.

dhensby avatar dhensby commented on July 16, 2024

@tractorcow thoughts on this? You recently did work on this stuff

from silverstripe-framework.

tractorcow avatar tractorcow commented on July 16, 2024

Yep, there's a bug in theme language files. I've updated the string detection code considerably, but it looks like localisation in the themes folder isn't working.

You might be better to move your strings to mysite/lang for the time being until it's fixed.

from silverstripe-framework.

chillu avatar chillu commented on July 16, 2024

I'm not sure if that's still an issue in 3.x, but it was definitely a regression in 4.x - which I've fixed with #6628

from silverstripe-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.