Comments (9)
How about having a separate field for each class?
I.e. instead of $index->filterFields['_subsite'] = array(
maybe $index->filterFields[$base . '_subsite'] = array(
in SearchVariantSubsites?
from silverstripe-fulltextsearch.
On second thought, that would probably break a huge amount of things. :) Maybe the array-base is better, and we just make sure to merge any existing config for subsequent calls to alterDefinition.
This doesn't seem like an easy problem to solve...
from silverstripe-fulltextsearch.
Yes, definitely one that will require some decent planning =)
from silverstripe-fulltextsearch.
We're fixing this now. :D Internal issue tracking: https://silverstripe.atlassian.net/browse/OSS-1737
from silverstripe-fulltextsearch.
I can confirm this doesn't just affect subsites, but also versioned.
from silverstripe-fulltextsearch.
I've tested a fix locally that seems to do the job... tractorcow@401afc5
Managed to do this without breaking changes. :)
Note that there is still only ONE field for all objects, but when adding objects multiple types may write to it. That way existing code that filters on that field won't break.
from silverstripe-fulltextsearch.
So this is fixed by still having a single _subsite
field for example, which still only accepts a single int
value - and the value might be overwritten by two different variants?
Makes sense for SearchVariantVersioned
and SearchVariantSubsites
, each document will only have one value for _subsite
or _versionedstage
.
from silverstripe-fulltextsearch.
@tractorcow so is this fixed?
from silverstripe-fulltextsearch.
Yep seems to have been merged in a while back https://github.com/silverstripe/silverstripe-fulltextsearch/blob/master/src/Search/Variants/SearchVariant.php
from silverstripe-fulltextsearch.
Related Issues (20)
- Is there a way of enforcing a sort? HOT 1
- Module shouldn't use file_get_contents to access external URLs HOT 3
- Module is utterly out of date HOT 4
- Filters are not escaped HOT 2
- Variant state not reset during processing. HOT 3
- Results not showing after editing pages (no soft-commit nor core reload issued) HOT 10
- Test and merge "allow update processor to be overridden by existing yml"
- Works fine on Dev, but on Prod many index files are missing and all owned by root (same database)
- Solr now at version 8 HOT 1
- Migrate to new Symfony cache classes HOT 5
- `SearchableService::isSearchable` incorrectly assumes return type of `canView` HOT 2
- Solr_Reindex build task doesn't work in dev mode in 3.9.0 HOT 4
- Allowing Symfony 3.2 or 4 can break reindexing HOT 10
- Stage param not being passed to Symfony
- 4.11.0-beta1 PHP 8.1 - Deprecation issue in solr-php-client HOT 1
- 4.11.0-beta2 PHP 8.1 - Changes in content are not reflected in search results HOT 7
- SearchIndex::fieldData is inefficient
- RFC: Search index update/new searcher on auto commit HOT 10
- 4.12 regression: Elemental block content not showing on search summary HOT 8
- `SearchVariant` replaced by `Injector` not consistent when used as part of `_documentid` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-fulltextsearch.