SearchVariantSubsites alterDefinition issue

[silverstripe]

SearchVariantSubsites alterDefinition issue

[tractorcow]

How about having a separate field for each class?

I.e. instead of $index->filterFields['_subsite'] = array( maybe $index->filterFields[$base . '_subsite'] = array( in SearchVariantSubsites?

[tractorcow]

On second thought, that would probably break a huge amount of things. :) Maybe the array-base is better, and we just make sure to merge any existing config for subsequent calls to alterDefinition.

This doesn't seem like an easy problem to solve...

[timkung]

Yes, definitely one that will require some decent planning =)

[tractorcow]

We're fixing this now. :D Internal issue tracking: https://silverstripe.atlassian.net/browse/OSS-1737

[tractorcow]

I can confirm this doesn't just affect subsites, but also versioned.

[tractorcow]

I've tested a fix locally that seems to do the job... tractorcow@401afc5

Managed to do this without breaking changes. :)

Note that there is still only ONE field for all objects, but when adding objects multiple types may write to it. That way existing code that filters on that field won't break.

[madmatt]

So this is fixed by still having a single _subsite field for example, which still only accepts a single int value - and the value might be overwritten by two different variants?

Makes sense for SearchVariantVersioned and SearchVariantSubsites, each document will only have one value for _subsite or _versionedstage.

[dhensby]

@tractorcow so is this fixed?

[tractorcow]

Yep seems to have been merged in a while back https://github.com/silverstripe/silverstripe-fulltextsearch/blob/master/src/Search/Variants/SearchVariant.php