Giter Site home page Giter Site logo

Comments (1)

robbieaverill avatar robbieaverill commented on August 15, 2024

I've been looking at this with @tractorcow - the reason that this RequestFilter exists is to bind the manipulation capture for the Database class.

We can replace this with Injector definitions that overload the class instead, or potentially even just remove all of the capture classes and use existing (and one new) extension points e.g. DataObject augmentWrite.

I tested this locally with mostly successful results, but the test suite took 400% longer to run which could be an indication that it's not a sustainable approach.

The Injector approach is good for now as it will improve the quality of the fulltextsearch module while also removing the need for this ticket, but it won't solve the same problem in the silverstripe-auditor module, which also needs to do the same thing. The extension approach would work for both modules, but again may be slower than normal.


For now I'm going to use Injector overloading instead, which makes this ticket redundant.

Closing. The changes will be implemented in #160 whilst re-implementing PostgreSQL.

from silverstripe-fulltextsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.