Giter Site home page Giter Site logo

Comments (4)

chillu avatar chillu commented on June 11, 2024

Agree its not ideal, particularly since the DB schema step can take a few seconds. Setting session state with the completed steps and some ajax timer would be nicer. Or websockets if we want to get fancy :)

The last step here is usually testing rewrite (see checkRewrite() in framework/dev/install/install.php5. Do you want to try and get a "done" step showing in the ajax response there?

Otherwise I'm inclined to close this ticket as an enhancement. As you know, open source usually has much more good ideas than are feasible to write code for. Our issue tracking policy is described here: http://docs.silverstripe.org/en/contributing/issues_and_bugs/

from silverstripe-installer.

RantyDave avatar RantyDave commented on June 11, 2024

All it needs is the word "done" at the bottom. As it is it looks like it's stuck "creating initial filesystem assets". Like in infamous Apple upgrade "completed in one minute". See what I mean?

Don't worry, I'll do it :)

from silverstripe-installer.

RantyDave avatar RantyDave commented on June 11, 2024

Huh. Can't repeat on 3.1.x-dev. I guess someone else got there first. Mark as closed?

from silverstripe-installer.

chillu avatar chillu commented on June 11, 2024

I don't think its implemented with a "done" step - just installed 3.1.12 and the last step is "friendly URLs set up successfully". See https://github.com/silverstripe/silverstripe-framework/blob/3.1/dev/install/install.php5#L1575. The whole install process is pretty quick here (1-2s, with SSD), so I don't think the "done" step will make much difference. As you can see in the code above, there's an artificial 2s delay before redirecting to "install successful", but that's by design. So closing this off for now, but feel free to dig into the installer and check how we can get better timely feedback to the user :)

from silverstripe-installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.