Comments (4)
Agree its not ideal, particularly since the DB schema step can take a few seconds. Setting session state with the completed steps and some ajax timer would be nicer. Or websockets if we want to get fancy :)
The last step here is usually testing rewrite (see checkRewrite()
in framework/dev/install/install.php5
. Do you want to try and get a "done" step showing in the ajax response there?
Otherwise I'm inclined to close this ticket as an enhancement. As you know, open source usually has much more good ideas than are feasible to write code for. Our issue tracking policy is described here: http://docs.silverstripe.org/en/contributing/issues_and_bugs/
from silverstripe-installer.
All it needs is the word "done" at the bottom. As it is it looks like it's stuck "creating initial filesystem assets". Like in infamous Apple upgrade "completed in one minute". See what I mean?
Don't worry, I'll do it :)
from silverstripe-installer.
Huh. Can't repeat on 3.1.x-dev. I guess someone else got there first. Mark as closed?
from silverstripe-installer.
I don't think its implemented with a "done" step - just installed 3.1.12 and the last step is "friendly URLs set up successfully". See https://github.com/silverstripe/silverstripe-framework/blob/3.1/dev/install/install.php5#L1575. The whole install process is pretty quick here (1-2s, with SSD), so I don't think the "done" step will make much difference. As you can see in the code above, there's an artificial 2s delay before redirecting to "install successful", but that's by design. So closing this off for now, but feel free to dig into the installer and check how we can get better timely feedback to the user :)
from silverstripe-installer.
Related Issues (20)
- Version indicator in CMS should point to recipe version, not silverstripe/cms module version HOT 13
- new install results in duplicate assets yml config HOT 3
- Incude MFA module in new projects via installer HOT 6
- Failing tests on 4 branch HOT 1
- create-project includes an unnecessary .cow directory HOT 3
- Broken build - class org\bovigo\vfs\vfsStream is not found
- Broken build - multi-tab validation
- Broken build - Framework snippet undefined
- Composer update running out of memory on travis HOT 1
- Switch default mail transport to Swift_SendmailTransport HOT 10
- Does it support PHP 8.0.12? HOT 2
- Uncaught Exception: Error: no controller registered in SilverStripe\Dev\DevelopmentAdmin for: bulid IN GET dev/bulid HOT 1
- bad error message on invalid database password HOT 5
- CMS5 Upgrade all other installer dependencies HOT 2
- Broken builds HOT 1
- Broken builds HOT 1
- CMS 5: Ensure correct constraints for vendor-plugin and recipe-plugin before release HOT 2
- Unexpected new dev dependencies in recent installs HOT 4
- Could not find package silverstripe/installer with version 4.12.3. HOT 3
- Resources folder installed instead of _resources HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-installer.