Comments (4)
We've reverted the subsites change
from silverstripe-securityreport.
I've confirmed it as a regression, not just in the tests
from silverstripe-securityreport.
I've made a mistake in my thinking with that subsites pull request. In psuedo code, this is what I've changed it to do when you're asking which subsites can be accessed for a given permission code:
- Loop all subsites
- Set current subsite to each
- Ask Permission::checkMember whether the code is valid in the current state
I think the problem is that the permission check doesn't cross reference against the subsites a user's group can be used in, so they're all treated as global checks.
In practice the permission system seems to be working, but the API has clearly regressed since this report is broken.
I'll need to reintroduce some of the previous logic to run SQL queries against the member's groups in order to filter permissions available for each group the member is in, which is in turn filtered against the current subsite.
The Permission::checkMember() method won't work I don't think =(
from silverstripe-securityreport.
I've brain dumped at silverstripe/silverstripe-subsites#358 (comment)
from silverstripe-securityreport.
Related Issues (10)
- Array to string conversion in CSV report HOT 4
- Fix travis builds for master branch
- Move Scrutinizer repo to SS HOT 1
- Check and update module for SS4 compatibility where necessary HOT 1
- Add support for PostgreSQL HOT 5
- UX Overflow content hidden if screen width too narrow HOT 1
- Missing columns in report HOT 6
- Report title should be underneath actions toolbar HOT 5
- Permissions report column for subsites is at the start instead of the end HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-securityreport.