Giter Site home page Giter Site logo

Comments (7)

silverwind avatar silverwind commented on May 29, 2024

I disagree. peerDependencies are meant for plugin-style relation between packages, which I just don't see here. If you use request in you project that uses updates, you should use your own version of request.

from updates.

NetOpWibby avatar NetOpWibby commented on May 29, 2024

From the request-promise-native repo:

request is defined as a peer-dependency and thus has to be installed separately.

🤷🏾‍♂️

from updates.

silverwind avatar silverwind commented on May 29, 2024

It's a peer dependency to request-promise-native, not to consumers. But I think I may switch to another HTTP library to avoid headaches like this :)

from updates.

NetOpWibby avatar NetOpWibby commented on May 29, 2024

Alright, I’ll close this then.

from updates.

silverwind avatar silverwind commented on May 29, 2024

At least you made me explore other options and I found a faster http library in turn :)

from updates.

NetOpWibby avatar NetOpWibby commented on May 29, 2024

Oh wow! Never heard of that package. Looks like I'll be using it too, haha!

from updates.

silverwind avatar silverwind commented on May 29, 2024

It's what npm uses internally, pretty nice and supports proxies too (which is a requirement for me).

from updates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.