Giter Site home page Giter Site logo

Comments (8)

francescovgg avatar francescovgg commented on June 11, 2024

I guess the wrong _currentIdex calculation is due to DateTime.difference and Duration.inDays() disalignment when considering Daylight Saving Time, as also stated in DateTime.difference() documentation.

To fix this we have to compare dates in utc, e.g.:

/// Gets difference of days between [date] and calling object.
int getDayDifference(DateTime date) => 
    DateTime.utc(year, month, day).difference(DateTime.utc(date.year, date.month, date.day)).inDays.abs();

Have a look at PR #104

from flutter_calendar_view.

awatson32 avatar awatson32 commented on June 11, 2024

I guess the wrong _currentIdex calculation is due to DateTime.difference and Duration.inDays() disalignment when considering Daylight Saving Time, as also stated in DateTime.difference() documentation.

To fix this we have to compare dates in utc, e.g.:

/// Gets difference of days between [date] and calling object.
int getDayDifference(DateTime date) => 
    DateTime.utc(year, month, day).difference(DateTime.utc(date.year, date.month, date.day)).inDays.abs();

Have a look at PR #104

How would I go about fixing this locally until they can get this fix out?

from flutter_calendar_view.

ParthBaraiya avatar ParthBaraiya commented on June 11, 2024

Hello guys, Please let us know if this issue is still there in version 1.0.0

from flutter_calendar_view.

awatson32 avatar awatson32 commented on June 11, 2024

Hello guys, Please let us know if this issue is still there in version 1.0.0

I actually think this issue might have been introduced in 1.0.0, when I downgrade to 0.0.5 it seemed to go away. For me at least.

from flutter_calendar_view.

johnbmangold avatar johnbmangold commented on June 11, 2024

Downgrading to 0.0.5 from 1.0.0 also fixed the issue for me.

from flutter_calendar_view.

arekfajdek avatar arekfajdek commented on June 11, 2024

@ParthBaraiya yes - this bug is present in 1.0.0

from flutter_calendar_view.

arekfajdek avatar arekfajdek commented on June 11, 2024

how is this still labeled as waiting for a response? multiple people commented that this is a critical bug in version 1.0 - that basically makes this component unusable.
Do you guys have any plan on fixing this issue?

from flutter_calendar_view.

faiyaz-shaikh avatar faiyaz-shaikh commented on June 11, 2024

Fixed in 1.0.1 PR #136

from flutter_calendar_view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.