Memory leak on execute for allocated Arguments

[BrendanLacey]

Memory leak on execute for allocated Arguments

[simolus3]

Argh!! The _hasAllocatedArguments thing was probably a leftover from an earlier version, and I have forgotten about it during the refactor to share more code between wasm/ffi.

Looking at both underlying implementations which keep a list of allocated pointers and clear them after freeing them, there's no double-free risk with just removing that guard. Also, _deallocateArguments is only called in the Dart finalizer and in _reset(), which in turn only gets called immediately before binding new parameters. So there's no scenario in which the arguments could still be in use by sqlite3. So, I'll just remove the _hasAllocatedArguments flag entirely.

[simolus3]

Fixed in 2.4.2. Thank you very much for the detailed report and analysis!

[BrendanLacey]

Thank you, incredible speed with this. I'm used to large companies where it takes months to even get a bug report reviewed.