Giter Site home page Giter Site logo

Comments (4)

simonask avatar simonask commented on July 21, 2024

It seems like join is already present as chain?

I would suggest expressing split (or split_by?) as taking an input range instead of iterator pairs. Since strings can be implicitly converted to ranges, this would work:

auto strings = "a,b"sv | split_by(",") | to_vector(); // {"a"sv, "b"sv}

from rx-ranges.

Xecutor avatar Xecutor commented on July 21, 2024

I wasn't clear enough: join with separator, like inverse split : vector{{"aa","bb","cc"}} | join(":") yields std::string aa:bb:cc.

Arbitrary input range for split_by seems somewhat problematic. std::search takes two iterators of the same type as input.

from rx-ranges.

Hazurl avatar Hazurl commented on July 21, 2024

To be consistent with the rest of the library, join should return a range outputting an element every other index, a sink can then be used to create a string from it. Same for split, it should take a range and return a range of range like in_groups_of.

strip, on the other hand, seems hard to implement (given its definition in the python std lib). The end trim is not possible without a lookahead, which means an allocation to store the elements.

from rx-ranges.

Xecutor avatar Xecutor commented on July 21, 2024

If split_by should produce range of string_views, then these string_views should be constructed from pointer and size. I tried to do this with range as an input to split_by, but it looks quite cumbersome, and range based iterators being strictly forward iterators kind of incompatible with ability to takes distance between iterators and the memory not necessary will be continuous. The original idea was that split(" hello , world , foo , bar", ",') | string() | to_vector(); will produce vector of string_views to original string. Probably I'm missing something...

from rx-ranges.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.