unit tests failing with different chisq

[simonsobs]

unit tests failing with different chisq

[xgarrido]

I'm going to fix it because I just have found another issue when testing with MacOS. I will fix both of them and will close this issue when everything goes well. Thanks.

[xgarrido]

Yes, I'm pretty sure this is due to new camb release 1.3.0 https://github.com/cmbant/CAMB/releases/tag/1.3.0 Previous chi square values were computed with older camb release. You should update the tabulated values of chi square within your unit tests (we actually should also do the same).

[timothydmorton]

I'm happy to submit a PR to update the tests here with a version check of camb. Would that be welcome?

[timothydmorton]

In case it saves you a few minutes, the numbers I just got are here:

if LooseVersion(camb.__version__) < LooseVersion('1.3'):
    chi2s = {"tt": 1384.5669, "te": 1400.2760, "ee": 1428.7597, "tt-te-et-ee": 2412.9275}
else:
    chi2s = {"tt": 1384.8184, "te": 1400.4507, "ee": 1428.8454, "tt-te-et-ee": 2413.10375}

[xgarrido]

Ok given the values you provide and fixing gfortran binary link for MacOS machine, the CI pass again. Thanks for the notification.