`--generate-dir` works confusingly

[simonw]

`--generate-dir` works confusingly

[simonw]

Yeah that's a good call: generate_dir being resolved relative to that temporary directory is most definitely a bug!

[simonw]

Replicated that other bug locally:

datasette publish fly github.db -a wat --generate-dir foop --plugins plugins

Which does this:

  File "/Users/simon/.pyenv/versions/3.10.0/lib/python3.10/shutil.py", line 417, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/Users/simon/.pyenv/versions/3.10.0/lib/python3.10/shutil.py", line 254, in copyfile
    with open(src, 'rb') as fsrc:
IsADirectoryError: [Errno 21] Is a directory: 'plugins'

Code at fault is:

datasette-publish-fly/datasette_publish_fly/__init__.py

Lines 390 to 394 in 68b809f

	# Copy files from current directory to dir
	for file in pathlib.Path(".").glob("*"):
	shutil.copy(str(file), str(dir / file.name))
	(dir / "fly.toml").write_text(fly_toml, "utf-8")
	return

[simonw]

Used ChatGPT: