Comments (10)
Perhaps that should have made that a variable so we do not have to edit all those files everytime
from smf.
@Spuds I can do that, if you think it's fine :)
from smf.
Done:
https://github.com/DrDeejay/playpen/commit/91623e9d60deb1f3d8378a85efd51b366cbc876b
and
https://github.com/DrDeejay/playpen/commit/658d5d895fb251f081ad2e42fec6bc939bc82beb
I'm sure I've missed many things, but I wanted to be sure that it's fine this way before I start editing the other cache versions. :)
from smf.
There are many other places where ?fin20 is used, not only index template.
Also, I don't think yet another global like this is an answer, we're trying to remove them globals, not add to them.
from smf.
I understand. :) But a question though, in which file should it be put? I was thinking of using the context variable, but that one is defined later in index.php so I didn't know if it would be fine there. What do you think?
from smf.
My gut reaction was not to use a global (well once I saw it of course).
There are well over 40 places that ?fin20 is used, which is why they are missed from time to time :P
Don't know how folks feel about defining a constant for this purpose define('SMF_BROWSER_SALT', '?dev21') or some such thing. Don't know really.
from smf.
A constant sounds good to me :)
from smf.
str_replace(' ', '', $context['forum_version']);
:P
from smf.
I did consider that, but thought it was a bit clunky, even fro 2,1 :P
from smf.
Looks like we are going to leave this old school for this round ... find/replace
from smf.
Related Issues (20)
- Attachment downloads - if a file has an entity in the filename (e.g., &), it is entity-encoded in the name upon download
- SMTP Email - live server edits vs relay HOT 8
- Members should be able to see login history and profile edits
- There's only one chance to remove image attachments during preview
- PHP 8.3 session_set_save_handler 6 arguments deprecated
- Upgrader: Old protected_alter logic is producing deprecation warnings HOT 2
- Improve error reporting when a loop is detected
- Calendar - events dropped when there are multiple overlapping events HOT 8
- "No newline at end of file" policy HOT 3
- Inconsistent/wrong uses of "forums" HOT 1
- Add Sensitive Parameter attribute HOT 1
- "Awaiting Approval" tab not appearing in the ACP menu
- Remove or unify "sorry" strings HOT 12
- (Incompletely configured) Paid subs errors use language of the user in error log HOT 3
- Attachments are not deleted after uploading a new one. HOT 1
- Posts ending in [@ cause "Uninitialized string offset" errors HOT 1
- Upgrade converting UTF-8 may sometimes convert backup tables HOT 1
- Unable to delete some filtered errors
- Search custom index: log_search_words not built in correct collation HOT 4
- mysqli_prepare can return false HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smf.