simprints/libsimprints

libsimprints's Issues

Supplied proguard file does not work

Using the proguard file supplied at https://github.com/Simprints/LibSimprints/blob/master/proguard-rules.pro, I get the following error:

android.os.BadParcelableException: ClassNotFoundException when unmarshalling: com.simprints.libsimprints.Registration
        at android.os.Parcel.readParcelableCreator(Parcel.java:2438)
        at android.os.Parcel.readParcelable(Parcel.java:2359)
        at android.os.Parcel.readValue(Parcel.java:2265)
        at android.os.Parcel.readArrayMapInternal(Parcel.java:2620)
        at android.os.BaseBundle.unparcel(BaseBundle.java:221)
        at android.os.BaseBundle.containsKey(BaseBundle.java:269)
        at android.content.Intent.hasExtra(Intent.java:6047)
        ...

I found the following proguard configuration to work successfully:

-keep class * implements android.os.Parcelable {
    *;
}

Test Item 2

Gradle wrapper's `gradle` directory is missing

Checking out the project and running gradle wrapper gives the following error:

Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

It appears that the gradle directory normally included with gradlew has not been committed.

As per gradle docs at https://docs.gradle.org/current/userguide/gradle_wrapper.html:

Example 5.3. Wrapper generated files

Build layout

   simple/
     gradlew
     gradlew.bat
     gradle/wrapper/
       gradle-wrapper.jar
       gradle-wrapper.properties

All of these files should be submitted to your version control system.