Giter Site home page Giter Site logo

Comments (2)

schnittstabil avatar schnittstabil commented on July 19, 2024

Unfortunately, things aren't that easy. For example, the properties of rebB are not ignored:

const regB = /b/;
regB.foo = 42;

console.log(deepAssign({
	str: "a", reg: /a/
}, {
	str: "b", reg: regB
}).reg.foo);
// => 42

–You may want to read the open deep-assign/issues.


If you only search for a solution, please consider a different library (e.g. merge-options may fit you needs–disclaimer: I'm the author, and there are many other libraries).

Otherwise, I would be very, very happy if someone could contribute, but please read the arguments already mentioned in the issues. And keep in mind, the current goal is:

Recursive Object.assign()

Please also note, the more technical specification at http://www.ecma-international.org/ecma-262/6.0/#sec-object.assign

IMO, the ways out are:

  1. change the goal of deep-assign, i.e. create a PR, which changes the readme.md (implies a major version bump)
  2. create a new project, with a different goal (e.g. merge-options distinguishes plain and non-plain objects, which is not the goal of deep-assign)
  3. find a way to provide an options object, but without breaking compatibility in the base case(!)
  4. find an interpretation of of "recursive" and the "Object.assign()" algorithm, which justifies a new approach
  5. find something, I can't think of 😉

Bests, Michael

from deep-assign.

sindresorhus avatar sindresorhus commented on July 19, 2024

This module is now deprecated: b332062

from deep-assign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.