Possible race condition with deleting files in directory

[sindresorhus]

Possible race condition with deleting files in directory

[schnittstabil]

@IMPinball Thank you for reporting that. It is because we use Promise.all at the moment.
@sindresorhus You could assign me to fix it.

[sindresorhus]

👍

[dgreene1]

It looks like @schnittstabil has some kind of fix. Sorry for not being too familiar with forking, but will his solution join back up with the main del repository soon?

Thank you.

[schnittstabil]

Sorry I cannot reproduce that bug anymore.
@isiahmeadows, @dgreene1: Are you still experiencing that problem?

[dead-claudia]

Not anymore.

On Tue, Jan 12, 2016, 04:30 Michael Mayer [email protected] wrote:

Sorry I cannot reproduce that bug anymore.
@isiahmeadows https://github.com/isiahmeadows, @dgreene1
https://github.com/dgreene1: Are you still experiencing that problem?

—
Reply to this email directly or view it on GitHub
#43 (comment).

[dgreene1]

I see it about 1 in 10 times on my local dev machine. Our build server sees it pretty often. I think it's easier to recreate when you have multiple gulp tasks that are calling del since gulp is async.

Since it looks like there's already a fix from @schnittstabil, can we just get it pulled in @sindresorhus ?

[schnittstabil]

@dgreene1 Would it be possible to provide us your platform and a stack trace or your gulpfile?

As an interim solution you may want to use the fork in your package.json to check out its validity:

  "devDependencies": {
    "del": "github:schnittstabil/del#fix-race-condition"
  }

[schnittstabil]

Ping @dgreene1.

I've tried del in async (multiple promises) and parallel (multiple processes) mode on hundreds of deeply nested files and folders, without luck.

[schnittstabil]

Not reproducible anymore. Closing, but please re-open if it still occurs.

[cguinnup]

Have been receiving this error sporadically while using 2.2.1, just now reporting. (I see the latest is 2.2.2 but it doesn't seem to address this issue?) The ENOTEMPTY occurs 1 in 10 times as @dgreene1 mentioned, yet afterward I "ls -al" the dir and there aren't even hidden files inside.

Will be unable to use 'del' in our Gulp integration builds if it keeps failing unpredictably.

[schnittstabil]

@pizza2code Would it be possible to provide us your gulpfile?

The most likely reasons causing ENOTEMPTY:

1. creation and deletion of files are running concurrently
2. another process creates files during deletion.

An example of 1.

gulp.task('clean', function () {
  del('folder/**'); // missing 'return' !
});

gulp.task('default', ['clean'], function () {
  // create some files
});

An example of 2.:

A Finder instance may create .DS_Store files during deletion for some reason (see #42 (comment))

[cguinnup]

You're right, it was a process creating files during deletion. Sorry about that, and thanks for the help!

[nahtnam]

Sorry, dont want to bring up an old thread but the ^ above was right. A process was creating files during the deletion. If you are making use of promises, make sure you await or use .then(). I forgot the await when the files were being created, so it quickly moved on to the deletion phase, rendering the issue.