Comments (8)
For anyone in the future having the same issue with downloading multiple files, I went the path of doing them in order instead of setting up promises to resolve every file at once. Here's what I ended up with that worked for my use case:
async function downloadFiles(assetUrls: string[]) {
for (const url of assetUrls) {
await download(mainWindow, url, {
directory: assetsDirectory,
saveAs: false,
showBadge: false,
});
}
}
from electron-dl.
From what I can tell, our logic is sound:
Lines 54 to 56 in d87af7a
from electron-dl.
From what I can tell, our logic is sound:
Lines 54 to 56 in d87af7a
So this sounds like an Electron bug. I would recommend upgrading to the latest Electron version.
well I'll try to update the electron to the latest. Thanks. Gonna update here about the result
from electron-dl.
I can confirm this issue on Electron 10.3.1(Windows, Mac and Linux). Works fine with Electron 9.3.1(tested on Linux and Windows).
from electron-dl.
I can confirm this issue on Electron 10.3.1(Windows, Mac and Linux). Works fine with Electron 9.3.1(tested on Linux and Windows).
thanks for the info.. i can confirm the bug appears when download multiple files in parallel ( appears in electron 10, 8, 7 ).
IF only download single file the bug doesn't appear. My solution right now is by queue the download so only 1 download in a time. But its kinda messy.
any robust solution for multiple download in parallel?
from electron-dl.
@vitorizkiimanda @sindresorhus any update on this? I am facing a similar issue with downloading multiple files and getting the Save As dialog. Using Electron 10.1.3
from electron-dl.
Maybe related to this electron bug?
electron/electron#23273
from electron-dl.
For anyone in the future having the same issue with downloading multiple files, I went the path of doing them in order instead of setting up promises to resolve every file at once. Here's what I ended up with that worked for my use case:
async function downloadFiles(assetUrls: string[]) { for (const url of assetUrls) { await download(mainWindow, url, { directory: assetsDirectory, saveAs: false, showBadge: false, }); } }
well thanks @jonesaustindev , i created same approach with different style and it solve the problem ( eventhough not really solved the bug )
note : still waiting for the real solution for the bug
from electron-dl.
Related Issues (20)
- MULTIPLY BUG with DOWNLOAD (BIGGEST BUG 2021?) HOT 4
- Cannot find n ame 'Completed'. (new in 3.2) HOT 1
- Utilizing session.enableNetworkEmulation with ElectronDL HOT 1
- TypeError upon evaluation of download() arguments HOT 1
- how to use electron latest in electron-dl HOT 10
- Overwrite Option is flase. but, the same file name is specified in the directory, it is overwritten. HOT 2
- Status of tests and remote module HOT 1
- Downloads stuck on MacOS HOT 5
- Cannot read property 'getType' of null at getWindowFromWebContents
- cannot read 'getOwnerBrowserWindow' HOT 1
- Save-as dialog shows two periods before the SQLite file extension in the file type filter
- Property defination are different between index.d.ts and index.js
- Download URL with POST requests. HOT 1
- is there any sample project i can't make
- how can i make progress bar please help HOT 1
- When I change menu in navbar with route, it goes into loop
- how to post a json param
- Self signed certificate download not working.
- Get "Download Error" when using save as dialog and cancel button is pressed HOT 1
- Electron 30 support HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-dl.