Giter Site home page Giter Site logo

Comments (6)

iwuvjhdva avatar iwuvjhdva commented on May 27, 2024 1

The code above doesn't work for me, the promises get resolved immediately. Reducing files array to a single item and reusing the same code works perfectly.

from electron-dl.

MiroFurtado avatar MiroFurtado commented on May 27, 2024 1

Frustrating that the tip right above me is necessary. These promises shouldn't be getting resolved immediately!

Might submit a pull if I get around to it

from electron-dl.

joshuapinter avatar joshuapinter commented on May 27, 2024 1

Frustrating that the tip right above me is necessary. These promises shouldn't be getting resolved immediately!

Might submit a pull if I get around to it

Got bit by the same thing. Did you ever get around to submitting that Pull Request?

from electron-dl.

mafar avatar mafar commented on May 27, 2024

electron-dl-multi.zip
Sample zip

from electron-dl.

itzsaga avatar itzsaga commented on May 27, 2024

We implemented downloading an array of file objects like this and it works for us. Hopefully, you can garner how to extract what you need from this.

ipcMain.on("download-files", async (event, files) => {
  const downloadLocation = app.getPath("userData");

  const promises = files.map(file =>
    download(mainWindow, file.url, {
      saveAs: false,
      directory: downloadLocation,
      onProgress: progress => {
        event.sender.send("download-progress", { progress, file });
      }
    })
  );

  await Promise.all(promises);
});

from electron-dl.

theogravity avatar theogravity commented on May 27, 2024

I wrote a library that handles multiple downloads and fixes a lot of issues around using a save as dialog:

https://github.com/theogravity/electron-dl-manager

from electron-dl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.