Giter Site home page Giter Site logo

Comments (4)

silverwind avatar silverwind commented on June 2, 2024 1

IIRC, the service did not support HTTPS when the check was implemented, but it seems it now does, so we should switch to it:

$ curl http://captive.apple.com/hotspot-detect.html
<HTML><HEAD><TITLE>Success</TITLE></HEAD><BODY>Success</BODY></HTML>
$ curl https://captive.apple.com/hotspot-detect.html
<HTML><HEAD><TITLE>Success</TITLE></HEAD><BODY>Success</BODY></HTML>

from is-online.

sindresorhus avatar sindresorhus commented on June 2, 2024

@silverwind Do you remember why we use HTTP and not HTTPS for that?

from is-online.

sindresorhus avatar sindresorhus commented on June 2, 2024

How often can I check isOnline status using this lib?

As often as you want, but if you check too often, you're just wasting resources.

from is-online.

silverwind avatar silverwind commented on June 2, 2024

On second thought, I think it's specifically using HTTP because router interception only works for HTTP, not HTTPS (it can not offer a valid certificate unless one is pre-installed on the machine).

Still I think using HTTPS should be preferred. With it, the check will fail at either the connection or certificate verification stage when not online.

from is-online.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.