Giter Site home page Giter Site logo

1.1.1 breaks multipart form boundary about ky HOT 6 CLOSED

etfz avatar etfz commented on May 25, 2024 2
1.1.1 breaks multipart form boundary

from ky.

Comments (6)

spaceemotion avatar spaceemotion commented on May 25, 2024 2

Came across the same issue when a user reported file uploads no longer working in Firefox (which is via S3). Chrome still works however (and all other Chromium alternatives).

from ky.

sholladay avatar sholladay commented on May 25, 2024 1

So this issue only happens on non-Chromium?

We have a test for this that is currently passing.

At the moment, our browser tests only run against Chromium. However, we have the ability to test other browsers as well. We should probably add Firefox here. Just need to replace playwright-chromium with playwright and then import { firefox } from 'playwright'.

from ky.

kdelmonte avatar kdelmonte commented on May 25, 2024 1

Thanks for the guidance @sholladay. I can confirm this test indeed fails along with 4 others when using import { firefox } from 'playwright'.

image

This test passes in 1.1.0 although I did find that some others do not:

image

I am investigating now.

from ky.

sindresorhus avatar sindresorhus commented on May 25, 2024

// @kdelmonte

from ky.

kdelmonte avatar kdelmonte commented on May 25, 2024

I'll take a look.

from ky.

sindresorhus avatar sindresorhus commented on May 25, 2024

https://github.com/sindresorhus/ky/releases/tag/v1.1.2

from ky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.