Comments (4)
Propose an API.
I would argue that retries and timeouts are universally necessary because networks are unreliable. But cookies are much closer to your application logic.
from ky.
Well, yes and no.
The credentials: include
feature in a server-side fetch is an interesting concept, which is why 'tough-cookie' exists.
API could be as simple as:
import ky from 'ky';
import { CookieJar } from 'tough-cookie';
const cookieJar = new CookieJar();
await ky.post('https://example.com/login', {
body: "login=foo&password=bar",
cookieJar
});
console.log(
'session id =',
await cookiejar.getCookies("https://example.com").find(cookie => cookie.key === 'session_id')
);
const response = await ky('https://example.com/dashboard', {
cookieJar
});
tough-cookie handles most of the hard bits with domains and matching.
from ky.
It's easy to add with hooks 🤷
Unsure if it needs another separate package, or could live somewhere here
I.e. could be split, and used as:
import { withCookies } from "ky";
const client = ky.create(withCookies()); // registers necessary hooks, consumes tough-cookie
const apiClient = client.extend({ prefixUrl: "http://api.example.com" });
from ky.
Seems that got
already has this feature.
https://github.com/sindresorhus/got/blob/main/test/cookies.ts
From what I can tell, this is mainly useful for server-side users. But it's a valid use case.
from ky.
Related Issues (20)
- beforeError hook isn't called on 500 responses HOT 4
- how to send binary data? HOT 1
- Error: unsupported BodyInit type
- retry not working? HOT 1
- HTTPError json as unknown/type HOT 3
- Allow extend() to append to prefixUrl HOT 5
- Refresh token with ky: 2 calls instead of 1 HOT 2
- [TypeError: signal.throwIfAborted is not a function (it is undefined)] in React Native context HOT 5
- Set TimeoutError#cause to be Request or URL HOT 2
- New request in afterResponse hook with formData content HOT 1
- How to download files from external host
- Allow for logging network errors and JSON parse errors HOT 5
- retry and beforeRetry not triggered HOT 7
- Use `X-RateLimit-Reset` header to determine retry delay HOT 9
- Consider extracting the HTTPError logic to an external module HOT 4
- Add generic for HTTPError to type the response HOT 2
- Aggregated error on server side. HOT 1
- [Question] Does it support HTTP/2 ? (compraison with Got) HOT 2
- Change the default retry amount HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ky.