Giter Site home page Giter Site logo

Comments (8)

charakterziffer avatar charakterziffer commented on May 16, 2024 1

I’m pretty sure the smaller h1 is a feature, not a bug. Since HTML5 it’s possible, to ignore the “correct” header nesting, use only h1 and signal the subordination with nested sections or articles, see https://stackoverflow.com/questions/24986162/html5-nested-sections-and-heading-tags/24987792#24987792

Yes, browser may interpret this different, but if you resize the nested h1 back to it’s original size you prevent this possibility HTML5 offers. It would be more correct to enable this smaller sectioned headings in all browsers (IE 6/7, too), but because it depends heavily on the whole context, that may be difficult to do with normalize.css.

from modern-normalize.

ismamz avatar ismamz commented on May 16, 2024

Hi @sindresorhus! Are you just testing in the last version of Chrome and the last version of Firefox?

from modern-normalize.

sindresorhus avatar sindresorhus commented on May 16, 2024

Yes

from modern-normalize.

ismamz avatar ismamz commented on May 16, 2024

The h1 element has the same behavior in both browsers (within article or section too). So, the rule here it should not be necessary if you are "normalizing", otherwise it should be indicated as "opinionated".
Are you agree?

from modern-normalize.

sindresorhus avatar sindresorhus commented on May 16, 2024

@ismamz Try using git blame to see when it was introduced and why. There might be something you're missing. https://github.com/necolas/normalize.css/blame/master/normalize.css

from modern-normalize.

ismamz avatar ismamz commented on May 16, 2024

@sindresorhus Sorry, but I don't find the reason to keep this rule. Maybe I missing something. I did a test and there are no difference when you write h1 within nested HTML sections (section, aside, etc). By the way, a HTML test file could be useful.

from modern-normalize.

sindresorhus avatar sindresorhus commented on May 16, 2024

Sorry, but I don't find the reason to keep this rule.

That's why I'm asking you to dig into why it was added in the first place. Even if you can't reproduce it, doesn't mean it's not there for a good reason. I'm not saying this is the case here, but we should always dig into the origins to find out. These are the relevant commits: necolas/normalize.css@e9e2874 necolas/normalize.css@fc85cfb

from modern-normalize.

ismamz avatar ismamz commented on May 16, 2024

@charakterziffer I agree that it is a feature. How modern-normalize does not support IE and other older browsers that might have trouble with this, there is no need to support them. There is no reason to keep it in modern-normalize.css (it does not normalize), and perhaps it can be useful in modern-base.css.

Here is a related issue: #23

from modern-normalize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.