Giter Site home page Giter Site logo

Comments (3)

sindresorhus avatar sindresorhus commented on July 26, 2024

You might be right, but it was added for a reason, and it wouldn't be worth changing it now, in case it has some unforseen downsides.

from open.

ScottFreeCode avatar ScottFreeCode commented on July 26, 2024

To clarify, I don't mean that the argument could be removed altogether -- that would cause start to interpret the filename as the name of a new console window (which is, as I understand it, why it had to be added); I mean that using a string containing "" seems to escape the double-quotes and wrap them in another pair of quotes like start "\"\"", whereas the intention of calling start "" seems to be effected by using an empty string as the argument instead.

Although you're right -- it's working now and I don't know for sure that this obvservation holds for all versions of Node and all versions of Windows; without some way to test it automatically it's hard to say for sure that the behavior I'm seeing is consistent everywhere.

from open.

ScottFreeCode avatar ScottFreeCode commented on July 26, 2024

Actually did think of a potential automated test just now -- we could open a .bat script that takes some action to indicate success, then wait/watch for that action with an appropriate timeout (might need a little tuning) to be sure the batch script ran. Wouldn't necessarily uncover all possible issues with opening files, but at any rate would demonstrate that start is not misinterpreting the filename as a console window name and failing to run the file.

from open.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.