Unclear error message when checking NaN against the number type

Unclear error message when checking NaN against the number type

[sindresorhus]

I agree. That should be improved. I think we should do both suggestions.

[panva]

@sindresorhus would you prefer the first suggestion to be a breaking change in @sindresorhus/is or a special case added to ow?

[sindresorhus]

would you prefer the first suggestion to be a breaking change in @sindresorhus/is or a special case added to ow?

How would you fix it in @sindresorhus/is?

[panva]

@sindresorhus change https://github.com/sindresorhus/is/blob/v4.4.0/source/index.ts#L112-L113

to

		case 'number':
			return Number.isNaN(value) ? 'NaN' : 'number';

[sindresorhus]

Ah yes. Let's fix it in @sindresorhus/is, but it might take a while before we can do a major version there, so better to fix it in both places, actually.

[panva]

Ok, ignore #232 then.

[sindresorhus]

See comment update.