Clarify ImageMetaData Last Modified Time / etag value

[sixlabors]

Clarify ImageMetaData Last Modified Time / etag value

[deanmarcussen]

Awesome, yes that clears up any ambiguity, thanks.

[JimBobSquarePants]

Hi @deanmarcussen

Cheers for all the fixes over the weekend @JimBobSquarePants .

No worries! 😄

Regarding your question. Yeah, I can see why this is ambiguous. The source in this sense does not mean the image we are processing rather it means the metadata source. We reuse the same class to represent both source and cached image metadata.

So, there are 3 potential values for the property:

When representing an image to be processed.

ImageSharp.Web/src/ImageSharp.Web/Providers/PhysicalFileSystemProvider.cs

Line 63 in 5ad15ba

var metadata = new ImageMetaData(fileInfo.LastModified.UtcDateTime);

When representing an image that has previously been processed and cached.

ImageSharp.Web/src/ImageSharp.Web/ImageMetadata.cs

Line 116 in 5ad15ba

DateTime.TryParse(lastWriteTimeUtcString, null, DateTimeStyles.RoundtripKind, out DateTime lastWriteTimeUtc);

When representing a newly processed image to be cached.

ImageSharp.Web/src/ImageSharp.Web/Middleware/ImageSharpMiddleware.cs

Line 242 in 5ad15ba

cachedImageMetadata = new ImageMetaData(DateTime.UtcNow, image.Format.DefaultMimeType, maxAge);

I hope this makes sense?