Comments (3)
trusktr
commented on May 27, 2024
Uh oh, I just noticed that this applies with _attributeToAttributeMap and _attributeToPropertyMap too! Each new subclass will clobber other subclass definitions if they have the same attribute names.
It doesn't look like these problems exist in the latest master any more.
from skatejs.
trusktr
commented on May 27, 2024
I found the skate-5.2.4 commit and made a branch with the same name so that I could make a PR with the fixes: #1561
from skatejs.
treshugart
commented on May 27, 2024
It doesn't look like these problems exist in the latest master any more.
Can you confirm? If so can we close this?
from skatejs.
Related Issues (20)
- First sentence in README.md is not correct HOT 2
- CLI command is actually "skatejs" not "skate" HOT 2
- SkateJS ssr example just not working HOT 1
- How to submit a v5 bug fix? HOT 1
- Could we get docs on package/element in particular around ssr? HOT 2
- Module build coming out CJS. HOT 3
- Add docs how to handle attribute update scenario HOT 1
- @skatejs/element-react "Invalid component name" error on WebComponent disconnectedCallback
- Using `ReactDom.render` many many times is slow HOT 2
- Homepage is broken HOT 1
- @skatejs/element should export ES6 class rather than compiled one
- Check if object is a Skate Element and Get Properties HOT 1
- SSR throws error when first childNode is a web component HOT 2
- SSR: rendered Light DOM placement HOT 2
- SSR example not working?
- Jest env not working in Jest 27 HOT 1
- Todo List example is not found
- SSR demo in readme does not work HOT 1
- element-redom
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skatejs.