make-command in option #3 in verifying setup gives an error

[skatteetaten]

make-command in option #3 in verifying setup gives an error

[eivindberg-skd]

@claesgill - I'm unable to reproduce this error (from VDI) after:

• Giving my user appropriate rights to Docker
• Not using sudo (by starting from scratch and removing old boxes). (Thank you @zhenik )

From what I can gather, this issue can be closed.

[claesgill]

Hey @eivindberg-skd,

I tried recreating this issue, and in my end this works fine. I've used the following commands:

make presto-cli
presto:default> show tables;
presto:default> show catalogs;

Result:

09:29 $ make presto-cli
CID=$(docker run --rm -d --network host consul:1.8 connect proxy -token master -service presto-local -upstream presto:8080)
docker run --rm -it --network host prestosql/presto:341 presto --server localhost:8080 --http-proxy localhost:8080 --catalog hive --schema default --user presto --debug
docker rm -f $CID
Unable to find image 'prestosql/presto:341' locally
341: Pulling from prestosql/presto
75f829a71a1c: Pull complete 
826423656c28: Pull complete 
adc59b45210d: Pull complete 
a1112891496a: Pull complete 
Digest: sha256:f89b36ab70e3ca8e19661657759357565e8f98b710bd8d6b9a7e96f03c148d80
Status: Downloaded newer image for prestosql/presto:341
presto:default> show tables;
     Table     
---------------
 flattenedjson 
 iris          
 somejson      
 tweets        
(4 rows)

Query 20201105_083041_00010_dvt5u, FINISHED, 2 nodes
http://localhost:8080/ui/query.html?20201105_083041_00010_dvt5u
Splits: 19 total, 19 done (100.00%)
CPU Time: 0.0s total,   129 rows/s, 3.12KB/s, 3% active
Per Node: 0.0 parallelism,     0 rows/s,    24B/s
Parallelism: 0.0
Peak Memory: 0B
2.08 [4 rows, 99B] [1 rows/s, 48B/s]

presto:default> SHOW CATALOGS;
 Catalog 
---------
 hive    
 jmx     
 memory  
 system  
 tpcds   
 tpch    
(6 rows)

Query 20201105_083215_00011_dvt5u, FINISHED, 1 node
http://localhost:8080/ui/query.html?20201105_083215_00011_dvt5u
Splits: 19 total, 19 done (100.00%)
CPU Time: 0.0s total,     0 rows/s,     0B/s, 5% active
Per Node: 0.0 parallelism,     0 rows/s,     0B/s
Parallelism: 0.0
Peak Memory: 86.4KB
2.40 [0 rows, 0B] [0 rows/s, 0B/s]

presto:default> 

Is this still an issue for you, or can we close this issue?

[zhenik]

Docker works differently on mac. Docker runs on mac inside a virtual machine. It brings troubles especially when you want to use --network=host flag.

We had a discussion about it, but we had not updated Makefiles on all modules.
Discussion Skatteetaten/vagrant-hashistack-template#34 (comment)

PS. Try to avoid using sudo

[claesgill]

Ok, should we update the README with information with a link to how to install the presto cli? Alternatively, I can create an install-presto-cli method in the Makefile.

What do you think, @zhenik @eivindberg-skd ?

[zhenik]

Ok, should we update the README with information with a link to how to install the presto cli? Alternatively, I can create an install-presto-cli method in the Makefile.

What do you think, @zhenik @eivindberg-skd ?

Previously we had two commands.

1. For setup proxy via consul cli
2. Run presto cli from localmachine

[claesgill]

@claesgill - I'm unable to reproduce this error (from VDI) after:

• Giving my user appropriate rights to Docker
• Not using sudo (by starting from scratch and removing old boxes). (Thank you @zhenik )

From what I can gather, this issue can be closed.

Closing this issue based of the above comment.