Giter Site home page Giter Site logo

Comments (5)

claesgill avatar claesgill commented on July 4, 2024

I'm not sure why we would want to do this. I mean examples of using Vault creds is present in all the modules already.

from terraform-nomad-trino.

zhenik avatar zhenik commented on July 4, 2024

I'm not sure why we would want to do this. I mean examples of using Vault creds is present in all the modules already.

Supported:

  • Shared secret ref
  • minio secrets ref

Also, we might need to refactor variables.tf. There is typo with use_vault_secret_provider

variable "vault_secret" {
  type = object({
    use_vault_secret_provider = string,
    vault_kv_policy_name      = string,
    vault_kv_path             = string,
    vault_kv_secret_key_name  = string
  })
  description = "Set of properties to be able fetch shared cluster secret from vault"
  default = {
    use_vault_secret_provider = true
    vault_kv_policy_name      = "kv-secret"
    vault_kv_path             = "secret/data/presto"
    vault_kv_secret_key_name  = "cluster_shared_secret"
  }
}

from terraform-nomad-trino.

claesgill avatar claesgill commented on July 4, 2024

Ahh got it, thought you meant something else. Then I agree, not sure about providing additional examples though. Should just use the ones we already have, and turning on every feature. WDYT?

It's late and I don't have my glasses, but I can't see any typos 😅 What's the typo?

from terraform-nomad-trino.

zhenik avatar zhenik commented on July 4, 2024

Screenshot 2020-11-11 at 18 47 01

from terraform-nomad-trino.

claesgill avatar claesgill commented on July 4, 2024

Oh, thanks! I fixed it (only the typo) in this PR #79

from terraform-nomad-trino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.