`make up-standalone` does not work

[skatteetaten]

`make up-standalone` does not work

[claesgill]

I fixed this in #79 . Think we can close this issue!

[pdmthorsrud]

Does it fail as soon as the terraform task begins, or does it take a while?

[zhenik]

Does it fail as soon as the terraform task begins, or does it take a while?

When the terraform task begins, due to main.tf refer to non-existing variables.

IMHO. I want to mention, that I do not like using locals in examples. In my opinion, examples (main.tf files) should be straight forward and self-efficient, without defining additional variables in locals

[pdmthorsrud]

Right. I have no clue how I didn't catch this when making the standalone version earlier. Very weird

[pdmthorsrud]

IMHO. I want to mention, that I do not like using locals in examples. In my opinion, examples (main.tf files) should be straight forward and self-efficient, without defining additional variables in locals

Are you saying you'd like it to be a different variables.tf instead? Or that we should use another approach?

[zhenik]

Not different variables, just remove this block of code https://github.com/fredrikhgrelland/terraform-nomad-presto/blob/master/example/presto_standalone/main.tf#L1-L24

[pdmthorsrud]

I fixed this in #79 . Think we can close this issue!

Oh, nice! Sorry I'm not sure how that snuck its way into my PR 😅

[claesgill]

I fixed this in #79 . Think we can close this issue!

Oh, nice! Sorry I'm not sure how that snuck its way into my PR 😅

Probably because of the tests only tested the cluster example 😅