Giter Site home page Giter Site logo

Comments (8)

claesgill avatar claesgill commented on July 24, 2024 1

I fixed this in #79 . Think we can close this issue!

from terraform-nomad-trino.

pdmthorsrud avatar pdmthorsrud commented on July 24, 2024

Does it fail as soon as the terraform task begins, or does it take a while?

from terraform-nomad-trino.

zhenik avatar zhenik commented on July 24, 2024

Does it fail as soon as the terraform task begins, or does it take a while?

When the terraform task begins, due to main.tf refer to non-existing variables.

IMHO. I want to mention, that I do not like using locals in examples. In my opinion, examples (main.tf files) should be straight forward and self-efficient, without defining additional variables in locals

from terraform-nomad-trino.

pdmthorsrud avatar pdmthorsrud commented on July 24, 2024

Right. I have no clue how I didn't catch this when making the standalone version earlier. Very weird

from terraform-nomad-trino.

pdmthorsrud avatar pdmthorsrud commented on July 24, 2024

IMHO. I want to mention, that I do not like using locals in examples. In my opinion, examples (main.tf files) should be straight forward and self-efficient, without defining additional variables in locals

Are you saying you'd like it to be a different variables.tf instead? Or that we should use another approach?

from terraform-nomad-trino.

zhenik avatar zhenik commented on July 24, 2024

Not different variables, just remove this block of code https://github.com/fredrikhgrelland/terraform-nomad-presto/blob/master/example/presto_standalone/main.tf#L1-L24

from terraform-nomad-trino.

pdmthorsrud avatar pdmthorsrud commented on July 24, 2024

I fixed this in #79 . Think we can close this issue!

Oh, nice! Sorry I'm not sure how that snuck its way into my PR 😅

from terraform-nomad-trino.

claesgill avatar claesgill commented on July 24, 2024

I fixed this in #79 . Think we can close this issue!

Oh, nice! Sorry I'm not sure how that snuck its way into my PR 😅

Probably because of the tests only tested the cluster example 😅

from terraform-nomad-trino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.