Default dict value in JSONField causes non-valid JSON string stored in db.

[skorokithakis]

Default dict value in JSONField causes non-valid JSON string stored in db.

[ketanbhatt]

I found a workaround. Doing a json.dumps gets rid of the issue.

My dict was like:

mydic = { "key": "value"}

I stored it as valid json by:

class NotificationTemplate(models.Model):
    extra = JSONField(default=json.dumps(NOTIFICATION_TEMPLATE_EXTRA)))

Remove the json.dumps it gets stored as:

{ 'key': 'value'}

which is invalid

[skorokithakis]

Hmm, I wonder why get_default behaves like that. It's odd to me, because I've been setting the default to an empty dict ({}) for ages and it works fine, although this code would make it seem like it shouldn't work...

[nebril]

What django version are you on? I am working on 1.6.

[skorokithakis]

I've been through 1.5 to 1.7, and it's always worked. All my fields have always been JSONField(default={}).

[nebril]

That's really odd. Maybe your fields inherit from something more than just JSONField, with custom get_default?

[skorokithakis]

No, they're vanilla JSONFields... Are you seeing the problem when you save objects in the admin, perhaps?

[nebril]

Nope, but I think I have this problem mostly when I am using SQLite (in test environment). I will try to reproduce this and let you know.

[ketanbhatt]

A valid JSON would be something like {"key": "value"}
But if we store a static dict as the default, it gets stored as {'key': 'value'} which becomes an Invalid JSON.

Any workaround for this?

[skorokithakis]

Hmm, this definitely shouldn't be the case. Can you post a small sample that reproduces the problem?

[skorokithakis]

That's very odd. I'll try to have a look and see why this happens, thanks.

[skorokithakis]

Fixed in 6912356, as @nebril suggested. Thank you all for the report!