Giter Site home page Giter Site logo

Comments (11)

skorokithakis avatar skorokithakis commented on July 22, 2024

Thanks for this. Can you open a PR? Is it backwards-compatible?

from django-annoying.

beaugunderson avatar beaugunderson commented on July 22, 2024

@nutztherookie I don't think my technique is backwards-compatible though is the only issue :)

from django-annoying.

skorokithakis avatar skorokithakis commented on July 22, 2024

Thanks for the PR! If I understood correctly, this is to avoid the ValueError, right? In that case, the change is backwards-incompatible indeed, but does it work at all without this?

I haven't used 1.8 yet, and I rarely use this field, but if it breaks completely with 1.8, we should probably do it this way. Maybe adding a check for the Django version would be prudent.

from django-annoying.

andreasnuesslein avatar andreasnuesslein commented on July 22, 2024

It does work partially - I think pulling the object worked, but not auto-creating it. I will try and create a version-agnostic patch asap

from django-annoying.

andreasnuesslein avatar andreasnuesslein commented on July 22, 2024

actually.. I just tested a bit and I'm pretty sure it IS backward-compatible. tried django 1.7 and django 1.6 and both work fine with the new code.

from django-annoying.

skorokithakis avatar skorokithakis commented on July 22, 2024

Alright, it looks backwards-compatible to me too, and this is the way Django recommends, so I'll merge it, thank you!

from django-annoying.

andreasnuesslein avatar andreasnuesslein commented on July 22, 2024

@skorokithakis would it be okay for you to release django-annoying with this fixed?
It'd be better here at work to be able to pull from pypi (via pip)

Thanks a lot

from django-annoying.

skorokithakis avatar skorokithakis commented on July 22, 2024

Sure, no problem. I will do it shortly, thanks!

from django-annoying.

skorokithakis avatar skorokithakis commented on July 22, 2024

The dev->master diff tells me I made too many changes in my botched py3k attempt, so I'll have to fix those before I can release it...

from django-annoying.

Kobold avatar Kobold commented on July 22, 2024

Thanks for all the work! Just wanted to leave the feedback that AutoOneToOneField is the primary reason I use django-annoying.

from django-annoying.

andreasnuesslein avatar andreasnuesslein commented on July 22, 2024

thanks as well! and: same here ;)

On Tue, May 5, 2015 at 9:00 PM, Andy Kish [email protected] wrote:

Thanks for all the work! Just wanted to leave the feedback that
AutoOneToOneField is the primary reason I use django-annoying.


Reply to this email directly or view it on GitHub
#36 (comment)
.

from django-annoying.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.