Comments (11)
Thanks for this. Can you open a PR? Is it backwards-compatible?
from django-annoying.
@nutztherookie I don't think my technique is backwards-compatible though is the only issue :)
from django-annoying.
Thanks for the PR! If I understood correctly, this is to avoid the ValueError
, right? In that case, the change is backwards-incompatible indeed, but does it work at all without this?
I haven't used 1.8 yet, and I rarely use this field, but if it breaks completely with 1.8, we should probably do it this way. Maybe adding a check for the Django version would be prudent.
from django-annoying.
It does work partially - I think pulling the object worked, but not auto-creating it. I will try and create a version-agnostic patch asap
from django-annoying.
actually.. I just tested a bit and I'm pretty sure it IS backward-compatible. tried django 1.7 and django 1.6 and both work fine with the new code.
from django-annoying.
Alright, it looks backwards-compatible to me too, and this is the way Django recommends, so I'll merge it, thank you!
from django-annoying.
@skorokithakis would it be okay for you to release django-annoying with this fixed?
It'd be better here at work to be able to pull from pypi (via pip)
Thanks a lot
from django-annoying.
Sure, no problem. I will do it shortly, thanks!
from django-annoying.
The dev->master diff tells me I made too many changes in my botched py3k attempt, so I'll have to fix those before I can release it...
from django-annoying.
Thanks for all the work! Just wanted to leave the feedback that AutoOneToOneField
is the primary reason I use django-annoying.
from django-annoying.
thanks as well! and: same here ;)
On Tue, May 5, 2015 at 9:00 PM, Andy Kish [email protected] wrote:
Thanks for all the work! Just wanted to leave the feedback that
AutoOneToOneField is the primary reason I use django-annoying.—
Reply to this email directly or view it on GitHub
#36 (comment)
.
from django-annoying.
Related Issues (20)
- Django 3.2 compatibility? HOT 1
- Tag the 0.8.0 and 0.8.1 releases HOT 1
- Can we get Pypi updated with the thread safe changes? HOT 1
- Test don't run against Django 1.7+ HOT 2
- Django 1.9 HOT 6
- Django 1.9: Cannot import name SingleRelatedObjectDescriptor HOT 4
- JSONField is not working in Django 1.9+
- AutoOneToOne doesn't work HOT 14
- Remove pretty-print from the JSON field output or make it configurable HOT 2
- Django 1.11 middleware HOT 3
- Please add a release with a universal wheel to PyPI HOT 1
- Could you publish a new release? HOT 4
- AutoOneToOneField breaks Django admin lookups HOT 5
- Using AutoOneToOneField with proxy model HOT 2
- Race Condition Fix HOT 3
- Setting HTTP status code when using ajax_request HOT 3
- ImportError: cannot import name 'six' HOT 2
- I know this is ancient history but a breaking change in a point release? HOT 6
- Support for django v3 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-annoying.