Giter Site home page Giter Site logo

Comments (2)

fcharras avatar fcharras commented on June 21, 2024 1

The bug was introduced in #648

@jeremiedbb apparently packaging only comes pre-installed with pip when using the conda distribution, otherwise it must be installed explicitly.

In this regard #648 seems like a regression should it be reverted, or still resorting to the package_resources way of doing if packaging is not found at least ?

package_resources has the disadvantage of outputting another warning because direct usage is discouraged, but in this particular case outside of conda distribution it's still the only native package with what is needed to check the dependency tree at runtime it seems.

The possible outcomes I see there would be either

  • add packaging as a dependency of skrub
  • fallback on the package_resources solution if packaging is not importable
  • revert #648

from skrub.

Vincent-Maladiere avatar Vincent-Maladiere commented on June 21, 2024 1

Thank you @baggiponte and @fcharras for the investigation! Closing this as #712 fixes the issue.

from skrub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.