DatetimeEncored can add holiday/weekend binary features

[baggiponte]

DatetimeEncored can add holiday/weekend binary features

[baggiponte]

I would love to work on both!

About the improved example: I currently cannot open it from the website. If I click on the link at this page nothing happens. Is that because the docs are not in sync with the latest commits, am I right? EDIT it's #716

As a reference, I guess the source code for the example you mention is here.

EDIT2: I was thinking about creating a custom function transformer to generate holiday features following the example Olivier wrote here. What do you think Vincent?

[Vincent-Maladiere]

Hey @baggiponte, thanks for the suggestion!

1. The weekend binary variable would bring value and is straightforward to implement!
2. The holidays package would add a new runtime dependency, and we prefer avoiding that.

Instead, we could improve one of our existing examples (and preferably increase its classification or regression score) using the holidays package as a documentation dependency. This way, we would demonstrate its usefulness while showcasing its usage with skrub.

Would you be interested in implementing one of those (or both)?

[Vincent-Maladiere]

1. Yes indeed, the documentation is being fixed, but you can access the source code file you mentioned.

   This file is actually generated via nbconvert, we sync a notebook to a python file, so that changes in the notebook are reflected in the file. We then manually process it to make it "sphinx compatible", i.e. we replace #% with ####### for cell breaks.

   Therefore, I suggest you reproduce example 03 in your own notebook, make the appropriate changes, and put these changes into the source file, trying to respect the sphinx syntax. I'll help you debug it if needed.

2. Seems like a good idea to use a light FunctionTransformer, go ahead!