Comments (4)
jovan-stojanovic
commented on June 21, 2024
1
Yes, indeed, you are right. This is IMO equivalent to #730 if we agree that we should rely on the backend for perfect matches..
from skrub.
GaelVaroquaux
commented on June 21, 2024
Good catch, this is an important special case.
Ideally, when there are only exact matches, we shouldn't even go down that code path and only use standard matching from the backend (pandas, polars...), as it will be much faster.
from skrub.
jeromedockes
commented on June 21, 2024
this is not the same as when the user requires perfect matches by setting match_score=1. This division by 0 is triggered when all rows happen to have a perfect match in the joined dataframe. it will be fixed by #802
from skrub.
jeromedockes
commented on June 21, 2024
fixed by #802
from skrub.
Related Issues (20)
- Polars deprecation inbound HOT 4
- InterpolationJoiner - polars HOT 1
- packaging>=23.1 - can it move to dev instead of install_required ? HOT 2
- incorrect github action matrix description
- Failing fetch ken embeddings test HOT 2
- Should accept pipelines and transformers HOT 1
- TableVectorizer raises when a categorical column contains `pd.NA` HOT 1
- Add features to the `DatetimeEncoder` HOT 16
- Hacky Idea: ifelse in a pipeline HOT 10
- Scikit-learn v1.5 breaks skrub HOT 4
- `drop_nulls` and `is_null` have a different behavior for polars and pandas HOT 1
- Follow-ups after #902
- GapEncoder and MinHashEncoder modify their input inplace HOT 2
- adding `make_learner` to create a default pipeline for a given predictor
- Shorthand for getting only the preprocessing part of the TableVectorizer HOT 2
- AggJoiner raises exceptions when trying to join multiple tables at once HOT 5
- Faster alternative to GapEncoder HOT 1
- Display columns with the HTML representation of the fitted TableVectorizer
- `fetch_ken_embeddings` does not use `suffix` with default parameter HOT 1
- Ken embeddings RAM and disk usage HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skrub.